From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752014AbdFTNYC (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 09:24:02 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:43918 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751131AbdFTNYB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 09:24:01 -0400
Date: Tue, 20 Jun 2017 06:24:00 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, sza@esh.hu, arnd@arndb.de,
        gregkh@linuxfoundation.org, akpm@linux-foundation.org,
        alexandre.torgue@st.com, robin.murphy@arm.com,
        benjamin.gaignard@linaro.org, kbuild-all@01.org,
        Joerg Roedel <jroedel@suse.de>,
        Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset
Message-ID: <20170620132400.GB11370@infradead.org>
References: <1495621472-9323-1-git-send-email-vladimir.murzin@arm.com>
 <1495621472-9323-2-git-send-email-vladimir.murzin@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1495621472-9323-2-git-send-email-vladimir.murzin@arm.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -		sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
> +		sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));

Needs a line break instead of the overly long line.

Otherwise this looks fine to me.