From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdFTUoY (ORCPT ); Tue, 20 Jun 2017 16:44:24 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34391 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbdFTUoW (ORCPT ); Tue, 20 Jun 2017 16:44:22 -0400 Date: Tue, 20 Jun 2017 21:44:18 +0100 From: Sudip Mukherjee To: Andy Shevchenko Cc: Dan Carpenter , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb Message-ID: <20170620204418.GB5603@sudip-laptop> References: <1497904378-4808-1-git-send-email-sudipm.mukherjee@gmail.com> <20170620200858.GA5287@sudip-laptop> <20170620202055.zhleonjxyzzrl5d3@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2017 at 11:40:59PM +0300, Andy Shevchenko wrote: > On Tue, Jun 20, 2017 at 11:20 PM, Dan Carpenter > wrote: > > That's totally bogus. Just say you don't know. It's never a > > reguirement that people fix AMD drivers before they can review code... > > Agree. It's not a cargo cult. > If there any real thing behind that #ifdef I would like to hear. I dont know the real thing behind that. You can hear the real thing if you send that patch to drm. And that is the only reason I mentioned that. -- Regards Sudip