From: David Sterba <dsterba@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: Nikolay Borisov <nborisov@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jens Axboe <axboe@fb.com>, Chris Mason <clm@fb.com>,
jbacik@fb.com, linux-mm@kvack.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jan Kara <jack@suse.com>,
mgorman@techsingularity.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch
Date: Wed, 21 Jun 2017 14:08:05 +0200 [thread overview]
Message-ID: <20170621120805.GG21388@suse.cz> (raw)
In-Reply-To: <20170620194759.GG21326@htj.duckdns.org>
On Tue, Jun 20, 2017 at 03:47:59PM -0400, Tejun Heo wrote:
> From 104b4e5139fe384431ac11c3b8a6cf4a529edf4a Mon Sep 17 00:00:00 2001
> From: Nikolay Borisov <nborisov@suse.com>
> Date: Tue, 20 Jun 2017 21:01:20 +0300
>
> Currently, percpu_counter_add is a wrapper around __percpu_counter_add
> which is preempt safe due to explicit calls to preempt_disable. Given
> how __ prefix is used in percpu related interfaces, the naming
> unfortunately creates the false sense that __percpu_counter_add is
> less safe than percpu_counter_add. In terms of context-safety,
> they're equivalent. The only difference is that the __ version takes
> a batch parameter.
>
> Make this a bit more explicit by just renaming __percpu_counter_add to
> percpu_counter_add_batch.
>
> This patch doesn't cause any functional changes.
>
> tj: Minor updates to patch description for clarity. Cosmetic
> indentation updates.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Chris Mason <clm@fb.com>
> Cc: Josef Bacik <jbacik@fb.com>
> Cc: David Sterba <dsterba@suse.com>
Acked-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2017-06-21 12:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 11:36 [PATCH 1/2] percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch Nikolay Borisov
2017-06-20 11:36 ` [PATCH 2/2] writeback: Rework wb_[dec|inc]_stat family of functions Nikolay Borisov
2017-06-20 17:33 ` Tejun Heo
2017-06-20 18:02 ` [PATCH v2 " Nikolay Borisov
2017-06-20 19:37 ` Tejun Heo
2017-06-20 20:28 ` Nikolay Borisov
2017-06-20 20:30 ` Tejun Heo
2017-06-20 20:32 ` Nikolay Borisov
2017-06-21 7:25 ` [PATCH v3] " Nikolay Borisov
2017-06-21 15:59 ` Tejun Heo
2017-06-22 8:38 ` Jan Kara
2017-06-21 0:05 ` [PATCH 2/2] " kbuild test robot
2017-06-20 17:28 ` [PATCH 1/2] percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch Tejun Heo
2017-06-20 18:01 ` [PATCH v2 " Nikolay Borisov
2017-06-20 19:47 ` [PATCH] " Tejun Heo
2017-06-20 19:55 ` David Miller
2017-06-21 1:14 ` Darrick J. Wong
2017-06-21 12:08 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621120805.GG21388@suse.cz \
--to=dsterba@suse.cz \
--cc=axboe@fb.com \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=jack@suse.com \
--cc=jbacik@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=nborisov@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).