From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753014AbdFVJFd (ORCPT ); Thu, 22 Jun 2017 05:05:33 -0400 Received: from mail.skyhub.de ([5.9.137.197]:46292 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbdFVJFc (ORCPT ); Thu, 22 Jun 2017 05:05:32 -0400 Date: Thu, 22 Jun 2017 11:05:13 +0200 From: Borislav Petkov To: Colin King Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/microcode/intel: make pointer intel_ucode_patch static Message-ID: <20170622090513.juhp6tqhl2phap3g@pd.tnic> References: <20170622084940.10286-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170622084940.10286-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 22, 2017 at 09:49:40AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer intel_ucode_patch does not need to be in global scope, > so make it static. > > Cleans up sparse warning: > "symbol 'intel_ucode_patch' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King > --- > arch/x86/kernel/cpu/microcode/intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c > index d525a0bd7d28..59edbe9d4ccb 100644 > --- a/arch/x86/kernel/cpu/microcode/intel.c > +++ b/arch/x86/kernel/cpu/microcode/intel.c > @@ -42,7 +42,7 @@ > static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin"; > > /* Current microcode patch used in early patching on the APs. */ > -struct microcode_intel *intel_ucode_patch; > +static struct microcode_intel *intel_ucode_patch; > > static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1, > unsigned int s2, unsigned int p2) > -- Acked-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.