From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753762AbdFVTEN (ORCPT ); Thu, 22 Jun 2017 15:04:13 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36887 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753486AbdFVTEL (ORCPT ); Thu, 22 Jun 2017 15:04:11 -0400 From: "Naveen N. Rao" To: Masami Hiramatsu Cc: Steven Rostedt , Ananth N Mavinakayanahalli , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/2] trace/kprobes: Sanitize derived event names Date: Fri, 23 Jun 2017 00:33:45 +0530 X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170622182953.e1959ce03145b8bb45ec55de@kernel.org> References: <20170622182953.e1959ce03145b8bb45ec55de@kernel.org> X-TM-AS-MML: disable x-cbid: 17062219-0008-0000-0000-0000014595AF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062219-0009-0000-0000-000009754551 Message-Id: <20170622190345.6444-1-naveen.n.rao@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-22_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706220324 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/06/22 06:29PM, Masami Hiramatsu wrote: > On Thu, 22 Jun 2017 00:20:27 +0530 > "Naveen N. Rao" wrote: > > > When we derive event names, convert some expected symbols (such as ':' > > used to specify module:name and '.' present in some symbols) into > > underscores so that the event name is not rejected. > > Oops, ok, this is my mistake. > > Acked-by: Masami Hiramatsu > > This must be marked as bugfix for stable trees. > > Could you also add a testcase for this (module name) bug? > > MODNAME=`lsmod | head -n 2 | tail -n 1 | cut -f 1 -d " "` > FUNCNAME=`grep -m 1 "\\[$MODNAME\\]" /proc/kallsyms | xargs | cut -f 3 -d " "` > > May gives you a target name :) Sure. Here is a test. Thanks for the review, Naveen - [PATCH] selftests/ftrace: Add a test to probe module functions Add a kprobes test to ensure that we are able to add a probe on a module function using 'p :' format, without having to specify a probe name. Suggested-by: Masami Hiramatsu Signed-off-by: Naveen N. Rao --- .../testing/selftests/ftrace/test.d/kprobe/probe_module.tc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc b/tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc new file mode 100644 index 000000000000..ea7657041ba6 --- /dev/null +++ b/tools/testing/selftests/ftrace/test.d/kprobe/probe_module.tc @@ -0,0 +1,14 @@ +#!/bin/sh +# description: Kprobe dynamic event - probing module + +[ -f kprobe_events ] || exit_unsupported # this is configurable + +echo 0 > events/enable +echo > kprobe_events +export MOD=`lsmod | head -n 2 | tail -n 1 | cut -f1 -d" "` +export FUNC=`grep -m 1 ".* t .*\\[$MOD\\]" /proc/kallsyms | xargs | cut -f3 -d" "` +[ "x" != "x$MOD" -a "y" != "y$FUNC" ] || exit_untested +echo p $MOD:$FUNC > kprobe_events +grep $MOD kprobe_events +echo > kprobe_events +clear_trace -- 2.13.1