From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754523AbdFWFJw (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Jun 2017 01:09:52 -0400
Received: from imap.thunk.org ([74.207.234.97]:34888 "EHLO imap.thunk.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754504AbdFWFJu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Jun 2017 01:09:50 -0400
Date: Fri, 23 Jun 2017 01:09:39 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: Chao Yu <yuchao0@huawei.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org, chao@kernel.org,
        Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH] ext4: check return value of kstrtoull correctly in
 reserved_clusters_store
Message-ID: <20170623050937.v2c44cyp3i7mtpnv@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
        Chao Yu <yuchao0@huawei.com>, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        chao@kernel.org, Miao Xie <miaoxie@huawei.com>
References: <20170615095730.36627-1-yuchao0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170615095730.36627-1-yuchao0@huawei.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 15, 2017 at 05:57:30PM +0800, Chao Yu wrote:
> kstrtoull returns 0 on success, however, in reserved_clusters_store we
> will return -EINVAL if kstrtoull returns 0, it makes us fail to update
> reserved_clusters value through sysfs.
> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Miao Xie <miaoxie@huawei.com>

Thanks, applied.

					- Ted