From: Greg KH <gregkh@linuxfoundation.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: core: sysfs: constify attribute_group
Date: Sat, 24 Jun 2017 09:55:36 +0200 [thread overview]
Message-ID: <20170624075536.GA9346@kroah.com> (raw)
In-Reply-To: <e5f70c22695d4fd9ef4ed9b4b164a9024b40eb59.1498197409.git.arvind.yadav.cs@gmail.com>
On Fri, Jun 23, 2017 at 11:28:10AM +0530, Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 6798 2848 4 9650 25b2 drivers/usb/core/sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 7230 2400 4 9634 25a2 drivers/usb/core/sysfs.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
You have sent a lot of these types of patches out, and really, this is a
horrible changelog entry. You are assuming that I know what this is,
and why it is a good thing. Now I might, but maybe not...
Please actually explain why you are making this change. Why it is
needed. And big hint, it's not only about the output of the file
size...
Please fix this up for all of the patches you have sent me in this
format, as I'm deleting them all from my queue right now.
thanks,
greg k-h
prev parent reply other threads:[~2017-06-24 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 5:58 [PATCH] usb: core: sysfs: constify attribute_group Arvind Yadav
2017-06-24 7:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624075536.GA9346@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).