From: Borislav Petkov <bp@alien8.de>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: kirill@shutemov.name, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, tj@kernel.org, rientjes@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed
Date: Mon, 26 Jun 2017 20:40:26 +0200 [thread overview]
Message-ID: <20170626184026.eztcwsqfy3yu7fvh@pd.tnic> (raw)
In-Reply-To: <20170502130453.5933-3-richard.weiyang@gmail.com>
On Tue, May 02, 2017 at 09:04:52PM +0800, Wei Yang wrote:
> numa_init() has already called init_func(), which is responsible for
> setting numa_nodes_parsed, so use this nodemask instead of re-finding it
> when calling numa_emulation().
>
> This patch gets the physnode_mask directly from numa_nodes_parsed. At
> the same time, it corrects the comment of these two functions.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Acked-by: David Rientjes <rientjes@google.com>
>
> ---
> v2: refresh the change log based on David Rientjes comment
> ---
> arch/x86/mm/numa_emulation.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c
> index eb017c816de6..a6d01931b9a1 100644
> --- a/arch/x86/mm/numa_emulation.c
> +++ b/arch/x86/mm/numa_emulation.c
> @@ -75,13 +75,15 @@ static int __init emu_setup_memblk(struct numa_meminfo *ei,
>
> /*
> * Sets up nr_nodes fake nodes interleaved over physical nodes ranging from addr
> - * to max_addr. The return value is the number of nodes allocated.
> + * to max_addr.
> + *
> + * Returns zero on success or negative error code.
... on error.
Other than that:
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-06-26 18:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 13:04 [PATCH V2 0/3] Refine numa_emulation Wei Yang
2017-05-02 13:04 ` [PATCH V2 1/3] x86/numa_emulation: fix potential memory leak Wei Yang
2017-06-26 15:31 ` Borislav Petkov
2017-06-26 23:11 ` Wei Yang
2017-06-27 18:10 ` Borislav Petkov
2017-06-27 23:37 ` Wei Yang
2017-05-02 13:04 ` [PATCH V2 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed Wei Yang
2017-06-26 18:40 ` Borislav Petkov [this message]
2017-06-26 23:12 ` Wei Yang
2017-05-02 13:04 ` [PATCH V2 3/3] x86/numa_emulation: restructures numa_nodes_parsed from emulated nodes Wei Yang
2017-06-06 3:15 ` [PATCH V2 0/3] Refine numa_emulation Wei Yang
2017-06-25 0:26 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626184026.eztcwsqfy3yu7fvh@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).