From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751466AbdFZSk6 (ORCPT ); Mon, 26 Jun 2017 14:40:58 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:35788 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbdFZSkw (ORCPT ); Mon, 26 Jun 2017 14:40:52 -0400 Date: Mon, 26 Jun 2017 13:40:50 -0500 From: Rob Herring To: Jacopo Mondi Cc: linus.walleij@linaro.org, andy.shevchenko@gmail.com, dongas86@gmail.com, geert+renesas@glider.be, Chris.Brandt@renesas.com, laurent.pinchart@ideasonboard.com, mark.rutland@arm.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pinctrl: generic: Add output-enable property Message-ID: <20170626184050.k4fibk5m42f47sug@rob-hp-laptop> References: <1498125658-14554-1-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498125658-14554-1-git-send-email-jacopo+renesas@jmondi.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 22, 2017 at 12:00:58PM +0200, Jacopo Mondi wrote: > Add output-enable generic pin configuration property. > This properties allows enabling/disabling pin's output capabilities > without actually driving any value on the line. > > --- > v1->v2: > - Expand the property description as suggested by Laurent. I ended up > mentioning the in-famous output buffer :) > > One (more) question to GPIO people on: > + PCONFDUMP(PIN_CONFIG_OUTPUT_ENABLE, "output enabled", NULL, false), > > I copied this from INPUT_ENABLE where arguments 2 and 3 passed to PCONFDUMP are > NULL and false even if the property has an argument, used to enable/disable > the input mode. Is this intended? Should that be turned instead to > - PCONFDUMP(PIN_CONFIG_INPUT_ENABLE, "input enabled", NULL, false), > + PCONFDUMP(PIN_CONFIG_INPUT_ENABLE, "input enabled", "enabled", true), > > Note that the same applies to most of the properties that have an > "enable"/"disable" argument. Just to make sure this is done on purpose. > > Thanks > j > .../devicetree/bindings/pinctrl/pinctrl-bindings.txt | 2 ++ Acked-by: Rob Herring > drivers/pinctrl/pinconf-generic.c | 3 +++ > include/linux/pinctrl/pinconf-generic.h | 15 +++++++++++---- > 3 files changed, 16 insertions(+), 4 deletions(-)