From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
brueckner@linux.vnet.ibm.com
Subject: Re: [PATCH] [PATCH v2] perf test: add platform dependency to test 15
Date: Mon, 26 Jun 2017 21:44:30 -0300 [thread overview]
Message-ID: <20170627004430.GA16387@kernel.org> (raw)
In-Reply-To: <20170626225828.GA19984@krava>
Em Tue, Jun 27, 2017 at 12:58:29AM +0200, Jiri Olsa escreveu:
> On Thu, Jun 22, 2017 at 09:36:25AM +0200, Thomas Richter wrote:
> > This patch adds platform dependency into the
> > test case 15 (perf_event_attr). It is based on a suggestion from
> > Jiri Olsa.
> > Add a new optional attribute named 'arch' in the [config] section
> > of the test case file. It is a comma separated list of architecture
> > names this test can be executed on. For example:
> >
> > arch = x86_64,alpha,ppc
> >
> > If this attribute is missing the test is executed on any platform.
> > This does not break existing behavior.
> > The values listed for this attribute should be identical to
> > uname -m output.
> > If the list starts with an exclamation mark (!) the comparison is
> > inverted, for example for
> >
> > arch = !s390x,ppc
> >
> > the test is not executed on s390x or ppc platforms.
> > The exclamation mark must be at the beginnning of the list.
> >
> > Here is an example debug output:
> > [root@s35lp76]# fgrep arch tests/attr/test-stat-C2
> > arch = x86_64,alpha,ppc
> > [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \
> > -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1
> >
> > provides the following output:
> >
> > running './tests/attr//test-stat-C1'
> > test limitation 'x86_64,alpha,ppc' <--- new
> > loading expected events
> > Event event:base-stat
> > fd = 1
> > group_fd = -1
> > .....
> >
> > Here is the output when a test is skipped:
> > [root@s35lp76]# fgrep arch tests/attr/test-stat-C1
> > arch = !s390x
> > [root@s35lp76]# PERF_TEST_ATTR=/tmp /usr/bin/python2 ./tests/attr.py \
> > -d ./tests/attr/ -p ./perf -vvvvv -t test-stat-C1
> >
> > provides the following output:
> > test limitation '!s390x' <--- new
> >
> > skipped [s390x] './tests/attr//test-stat-C1' <--- new
> >
> > The test is skipped with return code 0.
> >
> > Suggested-by: Jiri Olsa <jolsa@redhat.com>
> > Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> > Reviewed-by: Jiri Olsa <jolsa@redhat.com>
> > Reviwed-by: Arnaldo Carvalho de Melo <acme@kernel.org>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
>
> sorry for delay, I finished my attr tests fixes, you can check
> them in my perf/attr_test_2 branch.. still need to write changelogs ;-)
>
> it passes for me now, however we still might need few fixes
> due to different HW and supported events.. could you please
> test that on your system?
>
> I'll post the changes soon
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2017-06-27 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 7:36 [PATCH] [PATCH v2] perf test: add platform dependency to test 15 Thomas Richter
2017-06-26 22:58 ` Jiri Olsa
2017-06-27 0:44 ` Arnaldo Carvalho de Melo [this message]
2017-07-01 8:46 ` [tip:perf/core] perf tests: Add " tip-bot for Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627004430.GA16387@kernel.org \
--to=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).