From: Mark Rutland <mark.rutland@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>, lorenzo.pieralisi@arm.com
Cc: linux-arm-kernel@lists.infradead.org,
"Rob Herring" <robh+dt@kernel.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Gregory Fong" <gregory.0xf0@gmail.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Markus Mayer" <mmayer@broadcom.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Eric Anholt" <eric@anholt.net>,
"Justin Chen" <justinpopo6@gmail.com>,
"Doug Berger" <opendmb@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:BROADCOM BCM47XX MIPS ARCHITECTURE"
<linux-mips@linux-mips.org>,
linux-pm@vger.kernerl.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
will.deacon@arm.com, catalin.marinas@arm.com
Subject: Re: [PATCH 1/4] misc: sram: Allow ARM64 to select SRAM_EXEC
Date: Tue, 27 Jun 2017 18:38:59 +0100 [thread overview]
Message-ID: <20170627173859.GA5189@leverpostej> (raw)
In-Reply-To: <20170626223248.14199-3-f.fainelli@gmail.com>
On Mon, Jun 26, 2017 at 03:32:42PM -0700, Florian Fainelli wrote:
> Now that ARM64 also has a fncpy() implementation, allow selection
> SRAM_EXEC for ARM64 as well.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Sorr,y but I must NAK this patch.
As mentioned on prior threads regarding fncpy, I do not think it makes
sense to enable this for arm64. The only use-cases that have been
described so far for this are power-management stuff that should live in
PSCI or other secure FW, and have no place in the kernel on arm64.
There are no other users of this functionality, and until there are, I
see no reason to enable this, and risk a proliferation of unnecessary
platform-specific code.
It should be possible to #ifdef-ise the relevant callers of this such
that they can be built on arm64 without using fncpy or sram_exec
functionality. AFAICT, there are no users on arm64 introduced by this
series.
Thanks,
Mark.
> ---
> drivers/misc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 07bbd4cc1852..ac8779278c0c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -464,7 +464,7 @@ config SRAM
> bool "Generic on-chip SRAM driver"
> depends on HAS_IOMEM
> select GENERIC_ALLOCATOR
> - select SRAM_EXEC if ARM
> + select SRAM_EXEC if ARM || ARM64
> help
> This driver allows you to declare a memory region to be managed by
> the genalloc API. It is supposed to be used for small on-chip SRAM
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-06-27 17:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 22:32 [PATCH v2 0/4] Broadcom STB S2/S3/S5 support for ARM and MIPS Florian Fainelli
2017-06-26 22:32 ` [PATCH v2 1/4] dt-bindings: ARM: brcmstb: Update Broadcom STB Power Management binding Florian Fainelli
2017-06-28 23:23 ` Rob Herring
2017-06-26 22:32 ` [PATCH 1/4] misc: sram: Allow ARM64 to select SRAM_EXEC Florian Fainelli
2017-06-27 17:38 ` Mark Rutland [this message]
2017-06-27 18:21 ` Florian Fainelli
2017-06-28 14:57 ` Mark Rutland
2017-06-26 22:32 ` [PATCH 2/4] misc: sram-exec: Use aligned fncpy instead of memcpy Florian Fainelli
2017-06-26 22:32 ` [PATCH v2 2/4] soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM) Florian Fainelli
2017-06-27 18:01 ` Mark Rutland
2017-06-27 18:41 ` Florian Fainelli
2017-06-26 22:32 ` [PATCH v2 3/4] dt-bindings: Document MIPS Broadcom STB power management nodes Florian Fainelli
2017-06-26 22:32 ` [PATCH 3/4] dt-bindings: Document the Broadcom STB wake-up timer node Florian Fainelli
2017-06-26 22:32 ` [PATCH 4/4] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer Florian Fainelli
2017-06-26 22:32 ` [PATCH v2 4/4] soc bcm: brcmstb: Add support for S2/S3/S5 suspend states (MIPS) Florian Fainelli
2017-06-26 22:35 ` [PATCH v2 0/4] Broadcom STB S2/S3/S5 support for ARM and MIPS Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627173859.GA5189@leverpostej \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=hauke@hauke-m.de \
--cc=justinpopo6@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pm@vger.kernerl.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmayer@broadcom.com \
--cc=opendmb@gmail.com \
--cc=ralf@linux-mips.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).