From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: icenowy@aosc.io, techping.chan@gmail.com,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh@kernel.org>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T
Date: Tue, 27 Jun 2017 20:15:35 +0200 [thread overview]
Message-ID: <20170627181535.2nhd3rd542wpryjy@piout.net> (raw)
In-Reply-To: <20170627173631.2rjdzgwdwnksqjzm@flea>
On 27/06/2017 at 19:36:31 +0200, Maxime Ripard wrote:
> Hi,
>
> On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy@aosc.io wrote:
> > Maxime, here's another problem: if we have already a GP LRADC driver,
> > how can we tell the kernel to use it as IIO ADC rather than keys?
>
> The GPADC IIO driver is not for the LRADC driver, but the GPADC /
> temperature sensor.
>
> We used to have an LRADC IIO driver in the CHIP BSP written by Alex
> (in CC):
> https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27
>
> But he never mainlined it.
>
> > Should we introduce a new property for this once ready?
>
> We need to keep the current binding. We can just check for the
> presence or not of child nodes to see if it has some keys, and we'd
> need an IIO-to-input driver that is yet to be written.
>
The whole submission is here and can already replace the existing driver
but it will be polling instead of using interrupts:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-July/440734.html
It is not upstream because it seems the full replacement was required at
once instead of doing it incrementally and there was (is) no API for
in-kernel events consumers.
Also, the DT ABI stuff would have to be solved.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-06-27 18:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 2:45 [PATCH v3 0/3] Allwinner A83T R_LRADC support Ziping Chen
2017-06-24 2:45 ` [PATCH v3 1/3] input: sun4i-a10-lradc-keys: Add support for A83T Ziping Chen
2017-06-26 17:13 ` Maxime Ripard
2019-03-26 20:26 ` [linux-sunxi] " Ondřej Jirman
2017-06-24 2:45 ` [PATCH v3 2/3] dt-bindings: input: Add R_LRADC " Ziping Chen
2017-06-26 17:15 ` Maxime Ripard
2017-06-27 15:18 ` Ziping Chen
2017-06-27 15:29 ` [linux-sunxi] " icenowy
2017-06-27 17:36 ` Maxime Ripard
2017-06-27 18:15 ` Alexandre Belloni [this message]
2017-06-29 4:45 ` Ziping Chen
2017-06-29 7:53 ` Maxime Ripard
2017-06-29 12:19 ` Ziping Chen
2017-06-27 17:31 ` Maxime Ripard
2017-06-29 4:35 ` Ziping Chen
2017-06-29 7:52 ` Maxime Ripard
2017-06-24 2:45 ` [PATCH v3 3/3] ARM: dts: sunxi: " Ziping Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627181535.2nhd3rd542wpryjy@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh@kernel.org \
--cc=techping.chan@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).