From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753889AbdF0WYG (ORCPT ); Tue, 27 Jun 2017 18:24:06 -0400 Received: from gateway23.websitewelcome.com ([192.185.50.164]:31611 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbdF0WX7 (ORCPT ); Tue, 27 Jun 2017 18:23:59 -0400 Date: Tue, 27 Jun 2017 17:23:55 -0500 From: "Gustavo A. R. Silva" To: Willem Riede , "James E.J. Bottomley" , "Martin K. Petersen" Cc: osst-users@lists.sourceforge.net, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] scsi: osst: remove useless variable assignments in osst_int_ioctl() Message-ID: <20170627222355.GA8908@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.192.143 X-Exim-ID: 1dPyto-000vXV-Ae X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.192.143]:59322 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Value assigned to variable blkno at lines 4123:if (blkno >= 0) blkno += arg; and 4127:if (blkno >= 0) blkno -= arg; is overwritten at line 4131:blkno = STps->drv_block; before it can be used. This makes such variable assignments useless. Addresses-Coverity-ID: 1397685 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/osst.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 929ee7e..a62c1f2 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c @@ -4118,14 +4118,11 @@ static int osst_int_ioctl(struct osst_tape * STp, struct osst_request ** aSRpnt, printk(OSST_DEB_MSG "%s:D: Skipping %lu blocks %s from logical block %d\n", name, arg, cmd_in==MTFSR?"forward":"backward", logical_blk_num); #endif - if (cmd_in == MTFSR) { - logical_blk_num += arg; - if (blkno >= 0) blkno += arg; - } - else { - logical_blk_num -= arg; - if (blkno >= 0) blkno -= arg; - } + if (cmd_in == MTFSR) + logical_blk_num += arg; + else + logical_blk_num -= arg; + ioctl_result = osst_seek_logical_blk(STp, &SRpnt, logical_blk_num); fileno = STps->drv_file; blkno = STps->drv_block; -- 2.5.0