From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754037AbdF0XlA (ORCPT ); Tue, 27 Jun 2017 19:41:00 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:34438 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753975AbdF0Xkw (ORCPT ); Tue, 27 Jun 2017 19:40:52 -0400 Date: Tue, 27 Jun 2017 16:40:47 -0700 From: Bjorn Andersson To: Suman Anna Cc: Ohad Ben-Cohen , Arnd Bergmann , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs Message-ID: <20170627234047.GN18666@tuxbook> References: <20170627224610.15321-1-s-anna@ti.com> <20170627224610.15321-5-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170627224610.15321-5-s-anna@ti.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 27 Jun 15:46 PDT 2017, Suman Anna wrote: > Drop the dependency on RESET_CONTROLLER for the Keystone remoteproc > driver to resolve some circular dependencies around different choices > for RESET_CONTROLLER on common ARM configs. This dependency is > inherent as the RESET_CONTROLLER will be enabled due to the enabled > ARCH_HAS_RESET_CONTROLLER for ARCH_KEYSTONE. > As my approach requires synchronized changes to rproc-next and rpmsg-next and we're close to the merge window I'll pick this "workaround" for now, thanks! I do think it's appropriate for the Keystone remoteproc driver to express its dependency on reset-controller, so I intend to revert this as I look into this issue after -rc1 again. Merged all 4 patches. Regards, Bjorn > Signed-off-by: Suman Anna > --- > drivers/remoteproc/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index 945c1574f896..8891a8e50f12 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -70,7 +70,6 @@ config DA8XX_REMOTEPROC > config KEYSTONE_REMOTEPROC > tristate "Keystone Remoteproc support" > depends on ARCH_KEYSTONE > - depends on RESET_CONTROLLER > select RPMSG_VIRTIO > help > Say Y here here to support Keystone remote processors (DSP) > -- > 2.13.1 >