From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit
Date: Wed, 28 Jun 2017 07:05:23 +0900 [thread overview]
Message-ID: <20170628070523.ab19eeb9b9b0ac7e21e0705f@kernel.org> (raw)
In-Reply-To: <20170627100745.300bc747@gandalf.local.home>
On Tue, 27 Jun 2017 10:07:45 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 27 Jun 2017 17:38:30 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > On Thu, 22 Jun 2017 11:24:42 +0200
> > Sabrina Dubroca <sd@queasysnail.net> wrote:
> >
> > > Always try to parse an address, since kstrtoul() will safely fail when
> > > given a symbol as input. If that fails (which will be the case for a
> > > symbol), try to parse a symbol instead.
> > >
> > > This allows creating a probe such as:
> > >
> > > p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0
> > >
> > > Which is necessary for this command to work:
> > >
> > > perf probe -m 8021q -a vlan_gro_receive
> > >
> >
> > Ah, I forgot that case.
> > Nice catch!
> >
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> >
>
> Thanks Masami,
>
> I can take this. Should this go to stable?
Yes, it should go to stable.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2017-06-27 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 9:24 [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit Sabrina Dubroca
2017-06-27 8:38 ` Masami Hiramatsu
2017-06-27 14:07 ` Steven Rostedt
2017-06-27 22:05 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628070523.ab19eeb9b9b0ac7e21e0705f@kernel.org \
--to=mhiramat@kernel.org \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).