From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events
Date: Wed, 28 Jun 2017 10:04:38 -0300 [thread overview]
Message-ID: <20170628130438.GB3342@kernel.org> (raw)
In-Reply-To: <1495786658-18063-26-git-send-email-adrian.hunter@intel.com>
Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu:
> Add definitions for synthesized Intel PT events for power and ptwrite.
> +++ b/tools/perf/util/event.h
> +/*
> + * Raw data formats for synthesized events. Note that raw data plus the raw data
> + * size (4 bytes) must align to 8-bytes.
> + */
> +
> +struct perf_synth_intel_ptwrite {
> + union {
> + struct {
> + u32 ip : 1,
> + reserved : 31;
> + };
> + u32 flags;
> + };
> + u64 payload;
> +} __packed;
some versions of clang and gcc dislike this __packed here:
In file included from builtin-script.c:5:
In file included from /git/linux/tools/perf/util/debug.h:8:
/git/linux/tools/perf/util/event.h:274:2: error: packed attribute is unnecessary for (null) [-Werror,-Wpacked]
union {
^
/git/linux/tools/perf/util/event.h:285:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked]
u32 reserved;
^
/git/linux/tools/perf/util/event.h:298:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked]
u32 reserved;
^
/git/linux/tools/perf/util/event.h:322:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked]
u32 reserved;
^
4 errors generated.
mv: can't rename '/tmp/build/perf/.builtin-script.o.tmp': No such file or directory
/git/linux/tools/build/Makefile.build:101: recipe for target '/tmp/build/perf/builtin-script.o' failed
Failing in various distros:
[root@jouet ~]# waitp 3940 ; time dm
1 92.3684147260 alpine:3.4: FAIL
2 95.9136365930 alpine:3.5: FAIL
3 104.8328303770 alpine:3.6: FAIL
4 121.6584964930 alpine:edge: FAIL
5 37.2536373490 android-ndk:r12b-arm: Ok
6 83.9077612370 archlinux:latest: Ok
7 14.7094639200 centos:5: FAIL
8 16.6371634320 centos:6: FAIL
Investigating...
> +
> +struct perf_synth_intel_mwait {
> + u32 reserved;
> + union {
> + struct {
> + u64 hints : 8,
> + reserved1 : 24,
> + extensions : 2,
> + reserved2 : 30;
> + };
> + u64 payload;
> + };
> +} __packed;
> +
> +struct perf_synth_intel_pwre {
> + u32 reserved;
> + union {
> + struct {
> + u64 reserved1 : 7,
> + hw : 1,
> + subcstate : 4,
> + cstate : 4,
> + reserved2 : 48;
> + };
> + u64 payload;
> + };
> +} __packed;
> +
> +struct perf_synth_intel_exstop {
> + union {
> + struct {
> + u32 ip : 1,
> + reserved : 31;
> + };
> + u32 flags;
> + };
> +};
> +
> +struct perf_synth_intel_pwrx {
> + u32 reserved;
> + union {
> + struct {
> + u64 deepest_cstate : 4,
> + last_cstate : 4,
> + wake_reason : 4,
> + reserved1 : 52;
> + };
> + u64 payload;
> + };
> +} __packed;
> +
> +struct perf_synth_intel_cbr {
> + union {
> + struct {
> + u32 cbr : 8,
> + reserved1 : 8,
> + max_nonturbo : 8,
> + reserved2 : 8;
> + };
> + u32 flags;
> + };
> + u32 freq;
> + u32 reserved3;
> +};
> +
> /*
> * The kernel collects the number of events it couldn't send in a stretch and
> * when possible sends this number in a PERF_RECORD_LOST event. The number of
> --
> 1.9.1
next prev parent reply other threads:[~2017-06-28 13:04 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 8:17 [PATCH V2 00/37] perf intel-pt: Power events and PTWRITE Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 01/37] perf intel-pt: Move decoder error setting into one condition Adrian Hunter
2017-06-21 18:19 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 02/37] perf intel-pt: Improve sample timestamp Adrian Hunter
2017-06-21 18:20 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 03/37] perf intel-pt: Fix missing stack clear Adrian Hunter
2017-06-21 18:20 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 04/37] perf intel-pt: Ensure IP is zero when state is INTEL_PT_STATE_NO_IP Adrian Hunter
2017-06-21 18:21 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 05/37] perf intel-pt: Fix last_ip usage Adrian Hunter
2017-06-21 18:22 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 06/37] perf intel-pt: Ensure never to set 'last_ip' when packet 'count' is zero Adrian Hunter
2017-06-21 18:22 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 07/37] perf intel-pt: Use FUP always when scanning for an IP Adrian Hunter
2017-06-21 18:23 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 08/37] perf intel-pt: Clear FUP flag on error Adrian Hunter
2017-06-21 18:23 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 09/37] perf intel-pt: Add missing __fallthrough Adrian Hunter
2017-06-21 18:24 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 10/37] perf intel-pt: Allow decoding with branch tracing disabled Adrian Hunter
2017-06-21 18:24 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 11/37] perf intel-pt: Add default config for pass-through branch enable Adrian Hunter
2017-06-21 18:25 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 12/37] perf intel-pt: Add documentation for new config terms Adrian Hunter
2017-06-21 18:25 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 13/37] perf intel-pt: Add decoder support for ptwrite and power event packets Adrian Hunter
2017-06-21 18:26 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 14/37] perf intel-pt: Add reserved byte to CBR packet payload Adrian Hunter
2017-06-21 18:27 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 15/37] perf intel-pt: Add decoder support for CBR events Adrian Hunter
2017-06-21 18:27 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 16/37] perf intel-pt: Remove redundant initial_skip checks Adrian Hunter
2017-06-21 18:28 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 17/37] perf intel-pt: Fix transactions_sample_type Adrian Hunter
2017-06-21 18:28 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 18/37] perf tools: Fix message because cpu list option is -C not -c Adrian Hunter
2017-06-21 18:29 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 19/37] perf script: Fix message because field list option is -F not -f Adrian Hunter
2017-06-21 18:29 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 20/37] perf script: Add 'synth' event type for synthesized events Adrian Hunter
2017-06-21 10:17 ` [PATCH V3 " Adrian Hunter
2017-06-21 13:51 ` Arnaldo Carvalho de Melo
2017-06-21 16:41 ` Adrian Hunter
2017-06-21 17:29 ` Arnaldo Carvalho de Melo
2017-06-21 20:20 ` Adrian Hunter
2017-06-22 14:59 ` Arnaldo Carvalho de Melo
2017-07-01 8:50 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 21/37] perf script: Add 'synth' field for synthesized event payloads Adrian Hunter
2017-06-21 10:17 ` [PATCH V3 " Adrian Hunter
2017-07-01 8:51 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 22/37] tools include: Add byte-swapping macros to kernel.h Adrian Hunter
2017-07-01 8:50 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 23/37] perf auxtrace: Add itrace option to output ptwrite events Adrian Hunter
2017-07-01 8:51 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 24/37] perf auxtrace: Add itrace option to output power events Adrian Hunter
2017-07-01 8:51 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events Adrian Hunter
2017-06-28 13:04 ` Arnaldo Carvalho de Melo [this message]
2017-06-28 17:40 ` Adrian Hunter
2017-06-28 18:53 ` Arnaldo Carvalho de Melo
2017-06-28 20:21 ` Hunter, Adrian
2017-06-28 20:26 ` Arnaldo Carvalho de Melo
2017-06-29 19:56 ` Adrian Hunter
2017-06-29 20:13 ` Arnaldo Carvalho de Melo
2017-06-30 2:08 ` Arnaldo Carvalho de Melo
2017-06-30 8:51 ` Adrian Hunter
2017-06-30 14:54 ` Arnaldo Carvalho de Melo
2017-06-30 19:37 ` Hunter, Adrian
2017-06-30 8:36 ` [PATCH V3 " Adrian Hunter
2017-07-01 8:52 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 26/37] perf intel-pt: Factor out common code synthesizing event samples Adrian Hunter
2017-07-01 8:52 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 27/37] perf intel-pt: Remove unused instructions_sample_period Adrian Hunter
2017-07-01 8:52 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 28/37] perf intel-pt: Join needlessly wrapped lines Adrian Hunter
2017-07-01 8:53 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 29/37] perf intel-pt: Tidy Intel PT evsel lookup into separate function Adrian Hunter
2017-07-01 8:53 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 30/37] perf intel-pt: Tidy messages into called function intel_pt_synth_event() Adrian Hunter
2017-07-01 8:53 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 31/37] perf intel-pt: Factor out intel_pt_set_event_name() Adrian Hunter
2017-07-01 8:54 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 32/37] perf intel-pt: Move code in intel_pt_synth_events() to simplify attr setting Adrian Hunter
2017-07-01 8:54 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 33/37] perf intel-pt: Synthesize new power and ptwrite events Adrian Hunter
2017-06-30 8:36 ` [PATCH V3 " Adrian Hunter
2017-07-01 8:54 ` [tip:perf/core] perf intel-pt: Synthesize new power and "ptwrite" events tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 34/37] perf intel-pt: Add example script for power events and PTWRITE Adrian Hunter
2017-07-01 8:55 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 35/37] perf intel-pt: Update documentation to include new ptwrite and power events Adrian Hunter
2017-07-01 8:55 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 36/37] perf intel-pt: Do not use TSC packets for calculating CPU cycles to TSC Adrian Hunter
2017-07-01 8:56 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 37/37] perf auxtrace: Add CPU filter support Adrian Hunter
2017-07-01 8:56 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-06-12 13:04 ` [PATCH V2 00/37] perf intel-pt: Power events and PTWRITE Adrian Hunter
2017-06-12 13:56 ` Arnaldo Carvalho de Melo
2017-06-21 10:20 ` Adrian Hunter
2017-06-21 13:40 ` Arnaldo Carvalho de Melo
2017-06-27 15:27 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628130438.GB3342@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).