From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbdF1SKV (ORCPT ); Wed, 28 Jun 2017 14:10:21 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:36112 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbdF1SKQ (ORCPT ); Wed, 28 Jun 2017 14:10:16 -0400 Date: Wed, 28 Jun 2017 13:10:13 -0500 From: Rob Herring To: Bich HEMON Cc: Greg Kroah-Hartman , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Jiri Slaby , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 14/20] dt-bindings: serial: document option wake-up interrupt for STM32 USART Message-ID: <20170628181013.pv2f7acbckgnsnhg@rob-hp-laptop> References: <1498481318-1894-1-git-send-email-bich.hemon@st.com> <1498481318-1894-15-git-send-email-bich.hemon@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498481318-1894-15-git-send-email-bich.hemon@st.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2017 at 12:49:15PM +0000, Bich HEMON wrote: > From: Bich Hemon > > Introduce new compatibles for "st,stm32h7-usart" and "st,stm32h7-uart". > This new compatible allow to use optional wake-up interrupt. > > Signed-off-by: Fabrice Gasnier > --- > .../devicetree/bindings/serial/st,stm32-usart.txt | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt > index a229b14..3b42138 100644 > --- a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt > +++ b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt > @@ -2,11 +2,14 @@ > > Required properties: > - compatible: Can be either "st,stm32-usart", "st,stm32-uart", > -"st,stm32f7-usart" or "st,stm32f7-uart" depending on whether > -the device supports synchronous mode and is compatible with > -stm32(f4) or stm32f7. > +"st,stm32f7-usart", "st,stm32f7-uart", "st,stm32h7-usart" or > +st,stm32h7-uart depending on whether the device supports synchronous > +mode and is compatible with stm32(f4), stm32f7 or stm32h7. Please reformat as 1 valid set of compatibles per line. > - reg: The address and length of the peripheral registers space > -- interrupts: The interrupt line of the USART instance > +- interrupts or interrupts-extended: Must contain first, the interrupt > + line specifier for the USART instance. An optional wake-up interrupt > + specifier can be added. Then, -extended variant may be needed to specify > + interrupts parent controllers. Just describe the interrupts property and what the interrupts are. interrupts-extended is implied if it is necessary. > - clocks: The input clock of the USART instance > > Optional properties: > @@ -53,3 +56,12 @@ usart1: serial@40011000 { > <&dma2 7 4 0x414 0x0>; > dma-names = "rx", "tx"; > }; > + > +uart4: serial@40010000 { > + compatible = "st,stm32h7-uart"; > + reg = <0x40010000 0x400>; > + interrupts-extended = <&intc GIC_SPI 52 IRQ_TYPE_NONE>, > + <&aiec 30 1>; > + clocks = <&rcc UART4_K>; > + status = "disabled"; > +}; > -- > 1.9.1