From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbdF2Qww (ORCPT ); Thu, 29 Jun 2017 12:52:52 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42694 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbdF2Qwo (ORCPT ); Thu, 29 Jun 2017 12:52:44 -0400 Date: Thu, 29 Jun 2017 12:52:41 -0400 (EDT) Message-Id: <20170629.125241.1456732917773572552.davem@davemloft.net> To: jasowang@redhat.com Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jpmenil@gmail.com, john.fastabend@gmail.com Subject: Re: [PATCH net] virtio-net: serialize tx routine during reset From: David Miller In-Reply-To: <1498614663-7711-1-git-send-email-jasowang@redhat.com> References: <1498614663-7711-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 29 Jun 2017 09:10:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Wed, 28 Jun 2017 09:51:03 +0800 > We don't hold any tx lock when trying to disable TX during reset, this > would lead a use after free since ndo_start_xmit() tries to access > the virtqueue which has already been freed. Fix this by using > netif_tx_disable() before freeing the vqs, this could make sure no tx > after vq freeing. > > Reported-by: Jean-Philippe Menil > Tested-by: Jean-Philippe Menil > Fixes commit f600b6905015 ("virtio_net: Add XDP support") > Cc: John Fastabend > Signed-off-by: Jason Wang Applied and queued up for -stable.