From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbdF2MQ4 (ORCPT ); Thu, 29 Jun 2017 08:16:56 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:34073 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbdF2MQz (ORCPT ); Thu, 29 Jun 2017 08:16:55 -0400 Date: Thu, 29 Jun 2017 14:16:55 +0200 From: Alexandre Belloni To: Baruch Siach Cc: Claudiu Beznea , nicolas.ferre@microchip.com, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, sza@esh.hu, devicetree@vger.kernel.org, cristian.birsan@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support Message-ID: <20170629121655.37pq7cnabvv4wh7z@piout.net> References: <1498736674-9233-1-git-send-email-claudiu.beznea@microchip.com> <1498736674-9233-6-git-send-email-claudiu.beznea@microchip.com> <20170629115931.yki2xbehyicbtx3w@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170629115931.yki2xbehyicbtx3w@tarshish> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/2017 at 14:59:31 +0300, Baruch Siach wrote: > Hi Claudiu, > > On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: > > Add specifig DTS files and bindings for sama5d27 SoM1 EK board. > > Is there any publicly available information on this SoM? > > One more comment below. > > > Signed-off-by: Claudiu Beznea > > Signed-off-by: Cristian Birsan > > --- > > [snip] > > > + memory { > > + reg = <0x20000000 0x20000>; > > Are you sure this SoM has 132KB RAM? > > Since you seem to rely on the bootloader to fill in the right size value, you > can just drop this node and rely on sama5d2.dtsi that provides a stub node. > Yeah, that is what I would do too. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com