From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbdF2Ocd (ORCPT ); Thu, 29 Jun 2017 10:32:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55184 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbdF2Oc0 (ORCPT ); Thu, 29 Jun 2017 10:32:26 -0400 Date: Thu, 29 Jun 2017 16:32:24 +0200 From: Greg Kroah-Hartman To: Dmitriy Cherkasov Cc: devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH] staging: lustre: lnet: remove dead code Message-ID: <20170629143224.GA19857@kroah.com> References: <1498711356-14270-1-git-send-email-dmitriy@oss-tech.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498711356-14270-1-git-send-email-dmitriy@oss-tech.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2017 at 09:42:36PM -0700, Dmitriy Cherkasov wrote: > Remove code which was permanently disabled with ifdefs. > > This also resolves the following checkpatch warning which was > triggered by the dead code: > > WARNING: space prohibited before semicolon > > Signed-off-by: Dmitriy Cherkasov > --- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h > index 5540de6..7c487fa 100644 > --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h > +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h > @@ -521,13 +521,7 @@ struct ksock_proto { > > static inline __u32 ksocknal_csum(__u32 crc, unsigned char const *p, size_t len) > { > -#if 1 > return crc32_le(crc, p, len); Even better yet, why not just replace the callers of this tiny function, with crc32_le() instead and delete this useless wrapper? thanks, greg k-h