From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753686AbdF2SB4 (ORCPT ); Thu, 29 Jun 2017 14:01:56 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:39057 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753215AbdF2SBs (ORCPT ); Thu, 29 Jun 2017 14:01:48 -0400 Date: Thu, 29 Jun 2017 20:00:55 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Pierre Yves MORDRET Cc: Wolfram Sang , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Russell King , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver Message-ID: <20170629180055.ga6jgonch6dhowyi@pengutronix.de> References: <1497958890-5530-1-git-send-email-pierre-yves.mordret@st.com> <1497958890-5530-4-git-send-email-pierre-yves.mordret@st.com> <20170627205135.greh3baskzi4zetk@pengutronix.de> <21ca1ecb-39ac-5d43-71a2-d566974ab577@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21ca1ecb-39ac-5d43-71a2-d566974ab577@st.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:5054:ff:fe2a:3aa X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jun 29, 2017 at 02:40:44PM +0000, Pierre Yves MORDRET wrote: > >> + /* Arbitration loss */ > >> + if (status & STM32F7_I2C_ISR_ARLO) { > >> + dev_err(dev, "<%s>: Arbitration loss\n", __func__); > > > > Drop this. Arbitration loss is not an error and it shouldn't pollute the > > kernel log. > > > > I would like to keep it as indication though. > Agree with dev_warn ? No, dev_debug is ok. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |