From: Shaohua Li <shli@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
tj@kernel.org, gregkh@linuxfoundation.org, axboe@fb.com,
rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com,
Shaohua Li <shli@fb.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH V4 10/12] block: call __bio_free in bio_endio
Date: Thu, 29 Jun 2017 11:35:44 -0700 [thread overview]
Message-ID: <20170629183544.sgza7orhftb4zkg4@kernel.org> (raw)
In-Reply-To: <20170629171552.GA28502@lst.de>
On Thu, Jun 29, 2017 at 07:15:52PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 28, 2017 at 02:42:49PM -0700, Shaohua Li wrote:
> > > bio_integrity_endio -> bio_integrity_verify_fn -> bio_integrity_process
> > > access the integrity data, so I don't think this works as-is.
> >
> > oh, I probably missed the integrity endio. could we let bio_integrity_verify_fn
> > free integrity info and and bio_endio free cgroup info?
>
> something like this (will need the cgroup fixes from you still) should
> do the trick, although it's completely untested:
>
> diff --git a/block/bio-integrity.c b/block/bio-integrity.c
> index b8a3a65f7364..b66eb92b5a00 100644
> --- a/block/bio-integrity.c
> +++ b/block/bio-integrity.c
> @@ -102,7 +102,7 @@ EXPORT_SYMBOL(bio_integrity_alloc);
> * Description: Used to free the integrity portion of a bio. Usually
> * called from bio_free().
> */
> -void bio_integrity_free(struct bio *bio)
> +static void bio_integrity_free(struct bio *bio)
> {
> struct bio_integrity_payload *bip = bio_integrity(bio);
> struct bio_set *bs = bio->bi_pool;
> @@ -120,8 +120,8 @@ void bio_integrity_free(struct bio *bio)
> }
>
> bio->bi_integrity = NULL;
> + bio->bi_opf &= ~REQ_INTEGRITY;
> }
> -EXPORT_SYMBOL(bio_integrity_free);
>
> /**
> * bio_integrity_add_page - Attach integrity metadata
> @@ -340,12 +340,6 @@ int bio_integrity_prep(struct bio *bio)
> offset = 0;
> }
>
> - /* Install custom I/O completion handler if read verify is enabled */
> - if (bio_data_dir(bio) == READ) {
> - bip->bip_end_io = bio->bi_end_io;
> - bio->bi_end_io = bio_integrity_endio;
> - }
> -
> /* Auto-generate integrity metadata if this is a write */
> if (bio_data_dir(bio) == WRITE)
> bio_integrity_process(bio, bi->profile->generate_fn);
> @@ -370,14 +364,12 @@ static void bio_integrity_verify_fn(struct work_struct *work)
> struct blk_integrity *bi = bdev_get_integrity(bio->bi_bdev);
>
> bio->bi_status = bio_integrity_process(bio, bi->profile->verify_fn);
> -
> - /* Restore original bio completion handler */
> - bio->bi_end_io = bip->bip_end_io;
> + bio_integrity_free(bio);
> bio_endio(bio);
should we directly call bi_end_io here? Otherwise, looks reasonable to me.
Thanks,
Shaohua
next prev parent reply other threads:[~2017-06-29 18:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 16:29 [PATCH V4 00/12] blktrace: output cgroup info Shaohua Li
2017-06-28 16:29 ` [PATCH V4 01/12] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 02/12] kernfs: implement i_generation Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 03/12] kernfs: add an API to get kernfs node from inode number Shaohua Li
2017-06-28 18:07 ` Tejun Heo
2017-06-29 12:50 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 04/12] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 05/12] kernfs: introduce kernfs_node_id Shaohua Li
2017-06-29 12:51 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 06/12] kernfs: add exportfs operations Shaohua Li
2017-06-29 12:50 ` Greg KH
2017-06-28 16:29 ` [PATCH V4 07/12] cgroup: export fhandle info for a cgroup Shaohua Li
2017-06-28 18:12 ` Tejun Heo
2017-06-28 16:29 ` [PATCH V4 08/12] blktrace: export cgroup info in trace Shaohua Li
2017-06-28 16:56 ` Steven Rostedt
2017-06-28 16:29 ` [PATCH V4 09/12] block: always attach cgroup info into bio Shaohua Li
2017-06-28 16:30 ` [PATCH V4 10/12] block: call __bio_free in bio_endio Shaohua Li
2017-06-28 21:29 ` Christoph Hellwig
2017-06-28 21:42 ` Shaohua Li
2017-06-29 17:15 ` Christoph Hellwig
2017-06-29 18:35 ` Shaohua Li [this message]
2017-06-29 20:22 ` Christoph Hellwig
2017-06-28 16:30 ` [PATCH V4 11/12] blktrace: add an option to allow displying cgroup path Shaohua Li
2017-06-28 16:41 ` Jens Axboe
2017-06-28 16:30 ` [PATCH V4 12/12] block: use standard blktrace API to output cgroup info for debug notes Shaohua Li
2017-06-28 16:43 ` [PATCH V4 00/12] blktrace: output cgroup info Jens Axboe
2017-06-28 16:53 ` Shaohua Li
2017-06-28 16:54 ` Jens Axboe
2017-06-28 18:11 ` Tejun Heo
2017-06-28 20:57 ` Jens Axboe
2017-06-28 21:25 ` Tejun Heo
2017-06-29 12:50 ` Greg KH
2017-06-29 18:39 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629183544.sgza7orhftb4zkg4@kernel.org \
--to=shli@kernel.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=rostedt@goodmis.org \
--cc=shli@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).