From: Todd Kjos <tkjos@android.com> To: gregkh@linuxfoundation.org, arve@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, maco@google.com, tkjos@google.com Subject: [PATCH 16/37] binder: remove dead code in binder_get_ref_for_node Date: Thu, 29 Jun 2017 12:01:50 -0700 [thread overview] Message-ID: <20170629190211.16927-17-tkjos@google.com> (raw) In-Reply-To: <20170629190211.16927-1-tkjos@google.com> node is always non-NULL in binder_get_ref_for_node so the conditional and else clause are not needed Signed-off-by: Todd Kjos <tkjos@google.com> --- drivers/android/binder.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 3c1129d91825..3bbfb2455b70 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -670,18 +670,12 @@ static struct binder_ref *binder_get_ref_for_node(struct binder_proc *proc, } rb_link_node(&new_ref->rb_node_desc, parent, p); rb_insert_color(&new_ref->rb_node_desc, &proc->refs_by_desc); - if (node) { - hlist_add_head(&new_ref->node_entry, &node->refs); + hlist_add_head(&new_ref->node_entry, &node->refs); - binder_debug(BINDER_DEBUG_INTERNAL_REFS, - "%d new ref %d desc %d for node %d\n", - proc->pid, new_ref->debug_id, new_ref->desc, - node->debug_id); - } else { - binder_debug(BINDER_DEBUG_INTERNAL_REFS, - "%d new ref %d desc %d for dead node\n", - proc->pid, new_ref->debug_id, new_ref->desc); - } + binder_debug(BINDER_DEBUG_INTERNAL_REFS, + "%d new ref %d desc %d for node %d\n", + proc->pid, new_ref->debug_id, new_ref->desc, + node->debug_id); return new_ref; } -- 2.13.2.725.g09c95d1e9-goog
next prev parent reply other threads:[~2017-06-29 19:10 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-29 19:01 [PATCH 00/37] fine-grained locking in binder driver Todd Kjos 2017-06-29 19:01 ` [PATCH 01/37] Revert "android: binder: Sanity check at binder ioctl" Todd Kjos 2017-07-03 9:17 ` Greg KH [not found] ` <CAHRSSExh9JX5xiSRig55DSei31C_BPSasOKB+BTC6jjjuZ+ZpA@mail.gmail.com> 2017-07-05 18:47 ` Greg KH 2017-06-29 19:01 ` [PATCH 02/37] binder: use group leader instead of open thread Todd Kjos 2017-07-03 9:17 ` Greg KH [not found] ` <CAHRSSEyH3t0igLJqcC4e-HR68RH0bg4T310jnRHZzrMChoOeOg@mail.gmail.com> 2017-07-05 18:47 ` Greg KH 2017-07-07 18:23 ` Todd Kjos 2017-07-07 18:29 ` Greg KH 2017-07-24 21:00 ` John Stultz 2017-07-24 21:07 ` John Stultz 2017-07-25 9:13 ` Martijn Coenen 2017-07-27 9:08 ` Amit Pundir 2017-07-27 13:23 ` Greg Kroah-Hartman 2017-07-27 13:40 ` Martijn Coenen 2017-07-27 13:42 ` Amit Pundir 2017-07-28 11:58 ` Martijn Coenen 2017-07-24 21:23 ` Greg Kroah-Hartman 2017-07-24 21:53 ` John Stultz 2017-06-29 19:01 ` [PATCH 03/37] binder: Use wake up hint for synchronous transactions Todd Kjos 2017-07-03 9:18 ` Greg KH 2017-06-29 19:01 ` [PATCH 04/37] binder: separate binder allocator structure from binder proc Todd Kjos 2017-06-29 19:01 ` [PATCH 05/37] binder: remove unneeded cleanup code Todd Kjos 2017-06-29 19:01 ` [PATCH 06/37] binder: separate out binder_alloc functions Todd Kjos 2017-06-29 19:01 ` [PATCH 07/37] binder: move binder_alloc to separate file Todd Kjos 2017-06-29 19:01 ` [PATCH 08/37] binder: remove binder_debug_no_lock mechanism Todd Kjos 2017-06-29 19:01 ` [PATCH 09/37] binder: add protection for non-perf cases Todd Kjos 2017-06-29 19:01 ` [PATCH 10/37] binder: change binder_stats to atomics Todd Kjos 2017-06-29 19:01 ` [PATCH 11/37] binder: make binder_last_id an atomic Todd Kjos 2017-06-29 19:01 ` [PATCH 12/37] binder: add log information for binder transaction failures Todd Kjos 2017-06-29 19:01 ` [PATCH 13/37] binder: refactor queue management in binder_thread_read Todd Kjos 2017-06-29 19:01 ` [PATCH 14/37] binder: avoid race conditions when enqueuing txn Todd Kjos 2017-06-29 19:01 ` [PATCH 15/37] binder: don't modify thread->looper from other threads Todd Kjos 2017-06-29 19:01 ` Todd Kjos [this message] 2017-06-29 19:01 ` [PATCH 17/37] binder: protect against two threads freeing buffer Todd Kjos 2017-06-29 19:01 ` [PATCH 18/37] binder: add more debug info when allocation fails Todd Kjos 2017-06-29 19:01 ` [PATCH 19/37] binder: use atomic for transaction_log index Todd Kjos 2017-06-29 19:01 ` [PATCH 20/37] binder: refactor binder_pop_transaction Todd Kjos 2017-06-29 19:01 ` [PATCH 21/37] binder: guarantee txn complete / errors delivered in-order Todd Kjos 2017-06-29 19:01 ` [PATCH 22/37] binder: make sure target_node has strong ref Todd Kjos 2017-06-29 19:01 ` [PATCH 23/37] binder: make sure accesses to proc/thread are safe Todd Kjos 2017-06-29 19:01 ` [PATCH 24/37] binder: refactor binder ref inc/dec for thread safety Todd Kjos 2017-06-29 19:01 ` [PATCH 25/37] binder: use node->tmp_refs to ensure node safety Todd Kjos 2017-06-29 19:02 ` [PATCH 26/37] binder: introduce locking helper functions Todd Kjos 2017-06-29 19:02 ` [PATCH 27/37] binder: use inner lock to sync work dq and node counts Todd Kjos 2017-06-29 19:02 ` [PATCH 28/37] binder: add spinlocks to protect todo lists Todd Kjos 2017-06-29 19:02 ` [PATCH 29/37] binder: add spinlock to protect binder_node Todd Kjos 2017-06-29 19:02 ` [PATCH 30/37] binder: protect proc->nodes with inner lock Todd Kjos 2017-06-29 19:02 ` [PATCH 31/37] binder: protect proc->threads with inner_lock Todd Kjos 2017-06-29 19:02 ` [PATCH 32/37] binder: protect transaction_stack with inner lock Todd Kjos 2017-06-29 19:02 ` [PATCH 33/37] binder: use inner lock to protect thread accounting Todd Kjos 2017-06-29 19:02 ` [PATCH 34/37] binder: protect binder_ref with outer lock Todd Kjos 2017-06-29 19:02 ` [PATCH 35/37] binder: protect against stale pointers in print_binder_transaction Todd Kjos 2017-06-29 19:02 ` [PATCH 36/37] binder: fix death race conditions Todd Kjos 2017-06-30 6:05 ` Greg KH 2017-06-29 19:02 ` [PATCH 37/37] binder: remove global binder lock Todd Kjos 2017-06-30 6:04 ` [PATCH 00/37] fine-grained locking in binder driver Greg KH 2017-07-17 12:49 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170629190211.16927-17-tkjos@google.com \ --to=tkjos@android.com \ --cc=arve@android.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maco@google.com \ --cc=tkjos@google.com \ --subject='Re: [PATCH 16/37] binder: remove dead code in binder_get_ref_for_node' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).