From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>, Jiri Slaby <jslaby@suse.cz>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 3/8] objtool: stack validation 2.0
Date: Fri, 30 Jun 2017 10:32:03 +0200 [thread overview]
Message-ID: <20170630083203.7n5kbwieuoyjoov4@gmail.com> (raw)
In-Reply-To: <678bd94c0566c6129bcc376cddb259c4c5633004.1498659915.git.jpoimboe@redhat.com>
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> This is a major rewrite of objtool. Instead of only tracking frame
> pointer changes, it now tracks all stack-related operations, including
> all register saves/restores.
>
> In addition to making stack validation more robust, this also paves the
> way for undwarf generation.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Note, I have applied the first 3 patches, and got a bunch of new warnings on x86
64-bit allmodconfig:
arch/x86/kernel/alternative.o: warning: objtool: do_sync_core()+0x1b: unsupported instruction in callable function
arch/x86/kernel/alternative.o: warning: objtool: text_poke()+0x1a8: unsupported instruction in callable function
arch/x86/kernel/ftrace.o: warning: objtool: do_sync_core()+0x16: unsupported instruction in callable function
arch/x86/kernel/cpu/mcheck/mce.o: warning: objtool: machine_check_poll()+0x166: unsupported instruction in callable function
arch/x86/kernel/cpu/mcheck/mce.o: warning: objtool: do_machine_check()+0x147: unsupported instruction in callable function
(That's the vmlinux build - plus 4 more warnings in the modules build.)
That's with GCC 5.3.1.
Let me know if you need any more info.
Thanks,
Ingo
next prev parent reply other threads:[~2017-06-30 8:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 15:11 [PATCH v2 0/8] x86: undwarf unwinder Josh Poimboeuf
2017-06-28 15:11 ` [PATCH v2 1/8] objtool: move checking code to check.c Josh Poimboeuf
2017-06-30 13:12 ` [tip:core/objtool] objtool: Move " tip-bot for Josh Poimboeuf
2017-06-28 15:11 ` [PATCH v2 2/8] objtool, x86: add several functions and files to the objtool whitelist Josh Poimboeuf
2017-06-30 13:12 ` [tip:core/objtool] objtool, x86: Add " tip-bot for Josh Poimboeuf
2017-06-28 15:11 ` [PATCH v2 3/8] objtool: stack validation 2.0 Josh Poimboeuf
2017-06-30 8:32 ` Ingo Molnar [this message]
2017-06-30 13:23 ` Josh Poimboeuf
2017-06-30 13:26 ` Josh Poimboeuf
2017-06-30 14:09 ` [PATCH] objtool: silence warnings for functions which use iret Josh Poimboeuf
2017-06-30 17:49 ` [tip:core/objtool] objtool: Silence warnings for functions which use IRET tip-bot for Josh Poimboeuf
2017-06-30 13:13 ` [tip:core/objtool] objtool: Implement stack validation 2.0 tip-bot for Josh Poimboeuf
2017-06-28 15:11 ` [PATCH v2 4/8] objtool: add undwarf debuginfo generation Josh Poimboeuf
2017-06-29 7:14 ` Ingo Molnar
2017-06-29 13:40 ` Josh Poimboeuf
2017-06-29 7:25 ` Ingo Molnar
2017-06-29 14:04 ` Josh Poimboeuf
2017-06-29 14:46 ` Ingo Molnar
2017-06-29 15:06 ` Josh Poimboeuf
2017-07-06 20:36 ` Josh Poimboeuf
2017-07-07 9:44 ` Ingo Molnar
2017-07-11 2:58 ` Josh Poimboeuf
2017-07-11 8:40 ` Ingo Molnar
2017-06-28 15:11 ` [PATCH v2 5/8] objtool, x86: add facility for asm code to provide unwind hints Josh Poimboeuf
2017-06-28 15:11 ` [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf
2017-06-29 17:53 ` Josh Poimboeuf
2017-06-29 18:50 ` Andy Lutomirski
2017-06-29 19:05 ` Josh Poimboeuf
2017-06-29 21:09 ` Andy Lutomirski
2017-06-29 21:41 ` Josh Poimboeuf
2017-06-29 22:59 ` Andy Lutomirski
2017-06-30 2:12 ` Josh Poimboeuf
2017-06-30 5:05 ` Andy Lutomirski
2017-06-30 5:41 ` Andy Lutomirski
2017-06-30 13:11 ` Josh Poimboeuf
2017-06-30 15:44 ` Andy Lutomirski
2017-06-30 15:55 ` Josh Poimboeuf
2017-06-30 15:56 ` Andy Lutomirski
2017-06-30 16:16 ` Josh Poimboeuf
2017-06-28 15:11 ` [PATCH v2 7/8] x86/asm: add unwind hint annotations to sync_core() Josh Poimboeuf
2017-06-28 15:11 ` [PATCH v2 8/8] x86/unwind: add undwarf unwinder Josh Poimboeuf
2017-06-29 7:55 ` [PATCH v2 0/8] x86: " Ingo Molnar
2017-06-29 14:12 ` Josh Poimboeuf
2017-06-29 19:13 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630083203.7n5kbwieuoyjoov4@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).