From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbdF3QLj (ORCPT ); Fri, 30 Jun 2017 12:11:39 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:60857 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbdF3QLg (ORCPT ); Fri, 30 Jun 2017 12:11:36 -0400 From: Arnd Bergmann To: qla2xxx-upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Himanshu Madhani , Darren Trapp , Giridhar Malavali , Duane Grigsby , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap Date: Fri, 30 Jun 2017 18:10:39 +0200 Message-Id: <20170630161056.30630-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:g2vZe23fpL+U9yOpcpWnmEYFxBLn1vw3CrI8KzeQ1zLGFssRWj0 axx6hMlvF+S643k4MMAre5NhheaLl6cj96DJz0kzT9RAWHp61CqVtRn+Ux8wAnekWb8pAys NKlpbUUelFsWRa1pbi0cGetq4HjHTNqeTeqo1mDroYVIFSM5bwmraDfRb896BUSS96Mv7aC MITt40Lb0QYgNBrIwxo/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:8gQEsztppTo=:r+i7IYti9PFBtlPF1H+sCa ob9wvT9i6PaS5x+pGqF0ncWDyxLwqFYhf3sxnYZQl6G2egHON29cpRGwRe9ncbmptQ4AlrRrC C1bpJ/UYks7+YZ1Edy4wVRAOvFQIUdfrAAAJYK9Ja1l0aie8dyLLhe7EvGANEH2Db5kOl2X5w 5caw+vx1jv4trFVDnIdzIxb8PFZPoY8wDgqttePHhnS2W3iGtgpGkDUw8n/kvcEIcMk1TPSj4 ZihMgFyAtZs9t1tISPLSEJSAqbWZT7JhlmSJI4OGxqPWPgdY7l4ulB5/vwJXYJfiNMDniXYje k1b8low16F6E2tdHb2TQi1D0haOa0AA1MIZWehh3VSYvK06Cnj07e70KLWN4eWCNutDSmarzg /ovpdw1Be1lvo6UUmfrw3Q88bs82vwklKX1DHYckhMePnDqGiQF3Z8whYVf4rwk4u5dS+OmaU UiIonSdPXF1sS6O12Qyg1Py3ZlfIsCzjJPnYwvSW+/Ze+OPgvUfwb1mI5MljUdq/YnY1nXhd3 HIRXjj8fvPd1dFwvi8tP2Au3t4+0KXPov+UiVZKzk2NIOEuf70o8fKMhw8TmyMHkVXAzTl1pf Nij9QoDkgZqOzY7zN8qDajNJ6ekkDt872wgpAx6VtUtkyPvxS7G/ILEsPcGcY4J4/d3VX6Jwr +XNnXxhnAe6m1FPWo5QcPi3GLf8hSaHMGzanp/NZqUJcS+PoepRpQFBylH6DFoqVE5Iw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cont_pkt->entry_type is an 8-bit field, so doing a 32-bit byteswap on it will store incorrect data: drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq': include/uapi/linux/byteorder/big_endian.h:32:26: error: large integer implicitly truncated to unsigned type [-Werror=overflow] drivers/scsi/qla2xxx/qla_nvme.c:444:27: note: in expansion of macro 'cpu_to_le32' cont_pkt->entry_type = cpu_to_le32(CONTINUE_A64_TYPE); This removes the erroneous cpu_to_le32(). Fixes: e84067d74301 ("scsi: qla2xxx: Add FC-NVMe F/W initialization and transport registration") Signed-off-by: Arnd Bergmann --- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 1da8fa8f641d..14e25e32e622 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c +++ b/drivers/scsi/qla2xxx/qla_nvme.c @@ -441,7 +441,7 @@ static int qla2x00_start_nvme_mq(srb_t *sp) req->ring_ptr++; } cont_pkt = (cont_a64_entry_t *)req->ring_ptr; - cont_pkt->entry_type = cpu_to_le32(CONTINUE_A64_TYPE); + cont_pkt->entry_type = CONTINUE_A64_TYPE; cur_dsd = (uint32_t *)cont_pkt->dseg_0_address; avail_dsds = 5; -- 2.9.0