From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbdF3Vrl (ORCPT ); Fri, 30 Jun 2017 17:47:41 -0400 Received: from gateway36.websitewelcome.com ([192.185.193.12]:27442 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152AbdF3Vrk (ORCPT ); Fri, 30 Jun 2017 17:47:40 -0400 Date: Fri, 30 Jun 2017 16:47:37 -0500 Message-ID: <20170630164737.Horde.XkAFPlkZTYgdXBu7_MH6YNz@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Sergei Shtylyov Cc: Bartlomiej Zolnierkiewicz , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure References: <20170630213056.GA12695@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dR3lJ-002Muk-TE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:49671 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 26 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sergei Shtylyov : > On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: > >> Print error message on platform_get_irq failure before return. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> Changes in v2: >> Print the return value of platform_get_irq on failure. >> >> drivers/ata/pata_imx.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c >> index d4caa23..66fb1ab 100644 >> --- a/drivers/ata/pata_imx.c >> +++ b/drivers/ata/pata_imx.c >> @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev) >> int ret; >> >> irq = platform_get_irq(pdev, 0); >> - if (irq < 0) >> + if (irq < 0) { >> + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq); >> return irq; >> - >> + } > > Removing empty line here doesn't seem a good idea... > Oh yeah, I agree. I'll send v3 shortly. Thanks! -- Gustavo A. R. Silva