From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH v3] pata_imx: print error message on platform_get_irq failure
Date: Fri, 30 Jun 2017 17:03:48 -0500 [thread overview]
Message-ID: <20170630220348.GA15021@embeddedgus> (raw)
In-Reply-To: <20170630164737.Horde.XkAFPlkZTYgdXBu7_MH6YNz@gator4166.hostgator.com>
Print error message on platform_get_irq failure before return.
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
Print the return value of platform_get_irq on failure.
Changes in v3:
Put back the blank line after the IF closing brace,
which was accidentally removed in v2.
drivers/ata/pata_imx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
index d4caa23..cdae3c0 100644
--- a/drivers/ata/pata_imx.c
+++ b/drivers/ata/pata_imx.c
@@ -132,8 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
int ret;
irq = platform_get_irq(pdev, 0);
- if (irq < 0)
+ if (irq < 0) {
+ dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
return irq;
+ }
priv = devm_kzalloc(&pdev->dev,
sizeof(struct pata_imx_priv), GFP_KERNEL);
--
2.5.0
next prev parent reply other threads:[~2017-06-30 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 5:29 [PATCH] pata_imx: print error message on platform_get_irq failure Gustavo A. R. Silva
2017-06-30 21:30 ` [PATCH v2] " Gustavo A. R. Silva
2017-06-30 21:37 ` Sergei Shtylyov
2017-06-30 21:47 ` Gustavo A. R. Silva
2017-06-30 22:03 ` Gustavo A. R. Silva [this message]
2017-07-01 9:00 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630220348.GA15021@embeddedgus \
--to=garsilva@embeddedor.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).