From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmod: add dependencies for test module
Date: Sat, 1 Jul 2017 00:54:55 +0200 [thread overview]
Message-ID: <20170630225455.GX21846@wotan.suse.de> (raw)
In-Reply-To: <20170630154834.3689272-1-arnd@arndb.de>
On Fri, Jun 30, 2017 at 05:47:44PM +0200, Arnd Bergmann wrote:
> When we try to 'select' drivers whose dependencies are not met,
> we get a kconfig warning and undefined behavior as further 'select'
> statements in those drivers can not be honored:
>
> warning: (TEST_KMOD) selects TUN which has unmet direct dependencies (NETDEVICES && NET_CORE && INET)
> warning: (TEST_KMOD) selects XFS_FS which has unmet direct dependencies (BLOCK && (64BIT || LBDAF))
> ERROR: "iomap_zero_range" [fs/xfs/xfs.ko] undefined!
> ERROR: "iomap_fiemap" [fs/xfs/xfs.ko] undefined!
> ERROR: "iomap_page_mkwrite" [fs/xfs/xfs.ko] undefined!
>
> To work around that, this adds the dependencies required by the
> 'tun', 'xfs' and 'btrfs' modules for CONFIG_TEST_KMOD, guaranteeing
> that we can always enable those, and fixing the 'randconfig' issues.
>
> Unfortunately, there is another problem that I have not found a
> good solution for: If any of the three drivers are built-in rather
> than loadable modules, then the module load test will later fail
> at runtime.
>
> Fixes: ec159fed8677 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Luis
prev parent reply other threads:[~2017-06-30 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 15:47 [PATCH] kmod: add dependencies for test module Arnd Bergmann
2017-06-30 22:54 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630225455.GX21846@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).