From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid deadlock caused by lock order of page and lock_op
Date: Sat, 1 Jul 2017 00:28:27 -0700 [thread overview]
Message-ID: <20170701072827.GB83795@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <060e5c2d-50cd-9f76-9efc-0cdec0d3df3b@kernel.org>
On 06/26, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2017/6/26 22:54, Jaegeuk Kim wrote:
> > Hi Chao,
> >
> > On 06/26, Chao Yu wrote:
> >> Hi Jaegeuk,
> >>
> >> On 2017/6/25 0:25, Jaegeuk Kim wrote:
> >>> - punch_hole
> >>> - fill_zero
> >>> - f2fs_lock_op
> >>> - get_new_data_page
> >>> - lock_page
> >>>
> >>> - f2fs_write_data_pages
> >>> - lock_page
> >>> - do_write_data_page
> >>> - f2fs_lock_op
> >>
> >> Good catch!
> >>
> >> With this implementation, page writeback can fail due to concurrent checkpoint,
> >> this will make fsync/atomic_commit which trigger synchronous write failed randomly.
> >>
> >> How about unifying the lock order in punch_hole as one in writepages for regular
> >> inode? We can add one more parameter in get_new_data_page to indicate whether
> >> callee needs to lock cp_rwsem.
> >
> > Currently, there would be some places to keep cp_rwsem -> page.lock, which seems
> > not simple to change the lock order with page.lock -> cp_rwsem. IMO, we can retry
> > flushing data in f2fs_sync_file, once it gets -EAGAIN.
> >
> > Any thoughts?
>
> What about adding inode_lock in f2fs_sync_file to exclude other
> foreground operation which have reversed lock order? Atomic_commit is OK
> since it has inode_lock in its path.
I have concerned about performance regression, if we do that.
>
> Thanks,
>
> >
> >>
> >> Thanks,
> >>
> >>>
> >>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> >>> ---
> >>> fs/f2fs/data.c | 5 +++--
> >>> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> >>> index 7d3af48d34a9..9141bd19a902 100644
> >>> --- a/fs/f2fs/data.c
> >>> +++ b/fs/f2fs/data.c
> >>> @@ -1404,8 +1404,9 @@ int do_write_data_page(struct f2fs_io_info *fio)
> >>> }
> >>> }
> >>>
> >>> - if (fio->need_lock == LOCK_REQ)
> >>> - f2fs_lock_op(fio->sbi);
> >>> + /* Deadlock due to between page->lock and f2fs_lock_op */
> >>> + if (fio->need_lock == LOCK_REQ && !f2fs_trylock_op(fio->sbi))
> >>> + return -EAGAIN;
> >>>
> >>> err = get_dnode_of_data(&dn, page->index, LOOKUP_NODE);
> >>> if (err)
> >>>
> >
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> >
next prev parent reply other threads:[~2017-07-01 7:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 16:25 [PATCH 1/2] f2fs: avoid deadlock caused by lock order of page and lock_op Jaegeuk Kim
2017-06-24 16:25 ` [PATCH 2/2] f2fs: report # of free inodes more precisely Jaegeuk Kim
2017-06-26 10:52 ` [f2fs-dev] " Chao Yu
2017-06-26 14:58 ` Jaegeuk Kim
2017-06-28 13:01 ` Chao Yu
2017-07-01 7:27 ` Jaegeuk Kim
2017-07-01 8:28 ` Chao Yu
2017-06-26 8:15 ` [f2fs-dev] [PATCH 1/2] f2fs: avoid deadlock caused by lock order of page and lock_op Chao Yu
2017-06-26 14:54 ` Jaegeuk Kim
2017-06-26 15:42 ` Chao Yu
2017-07-01 7:28 ` Jaegeuk Kim [this message]
2017-07-01 8:41 ` Chao Yu
2017-07-01 14:27 ` Jaegeuk Kim
2017-07-05 2:58 ` Chao Yu
2017-07-05 3:28 ` Jaegeuk Kim
2017-07-07 19:13 ` [f2fs-dev] [PATCH 1/2 v2] " Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170701072827.GB83795@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).