From: Jonathan Cameron <jic23@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: Colin King <colin.king@canonical.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<linux-iio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static
Date: Sat, 1 Jul 2017 11:14:29 +0100 [thread overview]
Message-ID: <20170701111429.6e7ba6a9@kernel.org> (raw)
In-Reply-To: <29afb806-8634-0938-081b-dfab4efa04bf@st.com>
On Wed, 28 Jun 2017 16:35:04 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> On 06/28/2017 03:06 PM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The array stm32h7_adc_ckmodes_spec does not need to be in global scope, so
> > make it static.
> >
> > Cleans up sparse warning:
> > "symbol 'stm32h7_adc_ckmodes_spec' was not declared. Should it be static?"
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/iio/adc/stm32-adc-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> > index e09233b03c05..9d083c2338f9 100644
> > --- a/drivers/iio/adc/stm32-adc-core.c
> > +++ b/drivers/iio/adc/stm32-adc-core.c
> > @@ -172,7 +172,7 @@ struct stm32h7_adc_ck_spec {
> > int div;
> > };
> >
> > -const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> > +static const struct stm32h7_adc_ck_spec stm32h7_adc_ckmodes_spec[] = {
> > /* 00: CK_ADC[1..3]: Asynchronous clock modes */
> > { 0, 0, 1 },
> > { 0, 1, 2 },
> >
> Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-07-01 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 13:06 [PATCH][iio-next] iio: adc: stm32: make array stm32h7_adc_ckmodes_spec static Colin King
2017-06-28 14:35 ` Fabrice Gasnier
2017-07-01 10:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170701111429.6e7ba6a9@kernel.org \
--to=jic23@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=colin.king@canonical.com \
--cc=fabrice.gasnier@st.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).