From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbdGAL6K (ORCPT ); Sat, 1 Jul 2017 07:58:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:43880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbdGAL6G (ORCPT ); Sat, 1 Jul 2017 07:58:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3351022B57 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sat, 1 Jul 2017 12:58:01 +0100 From: Jonathan Cameron To: Brian Masney Cc: linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com Subject: Re: [PATCH 5/6] staging: iio: tsl2x7x: refactor {read,write}_event_value to allow handling multiple iio_event_infos Message-ID: <20170701125801.4bd58df9@kernel.org> In-Reply-To: <20170701103707.47bjnjxiv6a5353w@basecamp> References: <20170629170352.11264-1-masneyb@onstation.org> <20170629170352.11264-6-masneyb@onstation.org> <20170701104020.60257a88@kernel.org> <20170701103707.47bjnjxiv6a5353w@basecamp> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 1 Jul 2017 06:37:07 -0400 Brian Masney wrote: > On Sat, Jul 01, 2017 at 10:40:20AM +0100, Jonathan Cameron wrote: > > On Thu, 29 Jun 2017 13:03:51 -0400 > > Brian Masney wrote: > > > > > tsl2x7x_read_thresh() and tsl2x7x_write_thresh() currently assumes > > > that IIO_EV_INFO_VALUE is the only iio_event_info that will be > > > passed in. This patch refactors these two functions so that > > > additional iio_event_infos can be passed in. The functions are > > > renamed from tsl2x7x_{read,write}_thresh() to > > > tsl2x7x_{read,write}_event_value(). This patch also adds the > > > missing return value check to tsl2x7x_invoke_change() since this > > > was previously missing. > > > > > Hmm.. Why make this change? Are there additional uses of this > > function on the way? > > > > If not I wouldn't necessarily worry about the naming or the > > assumptions as the assumptions are enforced by the driver > > anyway. Nothing wrong with a bit of paranoid defence against > > future bugs, but it's not strictly necessary. > > I should have mentioned in the changelog that this change sets the > driver up for migrating the in_intensity0_thresh_period > and in_proximity0_thresh_period sysfs attributes to be created by > iio_event_spec. This is one of the patches that I held back until > I am able to properly test it. Cool. That's a good reason ;) > > Brian > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html