From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbdGBR5h (ORCPT ); Sun, 2 Jul 2017 13:57:37 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35980 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbdGBR5g (ORCPT ); Sun, 2 Jul 2017 13:57:36 -0400 Date: Sun, 2 Jul 2017 20:57:32 +0300 From: "Kirill A. Shutemov" To: Zi Yan Cc: kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net, mhocko@kernel.org, khandual@linux.vnet.ibm.com, zi.yan@cs.rutgers.edu, dnellans@nvidia.com, dave.hansen@intel.com, n-horiguchi@ah.jp.nec.com Subject: Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path Message-ID: <20170702175732.okngzb6y6gwxrpdo@node.shutemov.name> References: <20170701134008.110579-1-zi.yan@sent.com> <20170701134008.110579-6-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170701134008.110579-6-zi.yan@sent.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 01, 2017 at 09:40:03AM -0400, Zi Yan wrote: > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1302,6 +1302,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma, > bool ret = true; > enum ttu_flags flags = (enum ttu_flags)arg; > > + > /* munlock has nothing to gain from examining un-locked vmas */ > if ((flags & TTU_MUNLOCK) && !(vma->vm_flags & VM_LOCKED)) > return true; With exception of this useless hunk, looks good to me Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov