From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
NeilBrown <neil@brown.name>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Marek Belisko <marek@goldelico.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, letux-kernel@openphoenux.org,
notasas@gmail.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v7 2/2] power: supply: twl4030-charger: add deferred probing for phy and iio
Date: Mon, 3 Jul 2017 14:59:54 +0200 [thread overview]
Message-ID: <20170703125954.csrdoxlr3oda57m4@earth> (raw)
In-Reply-To: <63d2c2c5bfb1bb8ec006c1991bbd01e8d102c341.1497861705.git.hns@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 2020 bytes --]
Hi,
On Mon, Jun 19, 2017 at 10:41:46AM +0200, H. Nikolaus Schaller wrote:
> This fixes an issue if both this twl4030_charger driver and
> phy-twl4030-usb are compiled as modules and loaded in random order.
>
> It has been observed on GTA04 and OpenPandora devices that in worst
> case the boot process hangs and in best case the AC detection fails
> with a warning.
>
> Therefore we add deferred probing checks for the usb_phy and the
> iio channel for AC detection.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Looks fine to me.
-- Sebastian
> ---
> drivers/power/supply/twl4030_charger.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
> index 9d974f1e3957..0d2125e4f735 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -989,8 +989,12 @@ static int twl4030_bci_probe(struct platform_device *pdev)
>
> bci->channel_vac = devm_iio_channel_get(&pdev->dev, "vac");
> if (IS_ERR(bci->channel_vac)) {
> + ret = PTR_ERR(bci->channel_vac);
> + if (ret == -EPROBE_DEFER)
> + return ret; /* iio not ready */
> + dev_warn(&pdev->dev, "could not request vac iio channel (%d)",
> + ret);
> bci->channel_vac = NULL;
> - dev_warn(&pdev->dev, "could not request vac iio channel");
> }
>
> if (bci->dev->of_node) {
> @@ -1002,6 +1006,14 @@ static int twl4030_bci_probe(struct platform_device *pdev)
> bci->transceiver = devm_usb_get_phy_by_node(
> bci->dev, phynode, &bci->usb_nb);
> bci->usb_nb.notifier_call = twl4030_bci_usb_ncb;
> + if (IS_ERR(bci->transceiver)) {
> + ret = PTR_ERR(bci->transceiver);
> + if (ret == -EPROBE_DEFER)
> + return ret; /* phy not ready */
> + dev_warn(&pdev->dev, "could not request transceiver (%d)",
> + ret);
> + bci->transceiver = NULL;
> + }
> }
> }
>
> --
> 2.12.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-03 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 8:41 [PATCH v7 0/2] More fixes for twl4030 charger H. Nikolaus Schaller
2017-06-19 8:41 ` [PATCH v7 1/2] power: supply: twl4030-charger: move irq allocation to just before irqs are enabled H. Nikolaus Schaller
2017-07-03 12:55 ` Sebastian Reichel
2017-07-03 16:36 ` H. Nikolaus Schaller
2017-06-19 8:41 ` [PATCH v7 2/2] power: supply: twl4030-charger: add deferred probing for phy and iio H. Nikolaus Schaller
2017-07-03 12:59 ` Sebastian Reichel [this message]
2017-07-01 11:49 ` [PATCH v7 0/2] More fixes for twl4030 charger H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703125954.csrdoxlr3oda57m4@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=neil@brown.name \
--cc=notasas@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).