From: Mark Rutland <mark.rutland@arm.com>
To: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Songhe Wei <songhe.wei@spreadtrum.com>,
Zhongping Tan <zhongping.tan@spreadtrum.com>,
Orson Zhai <orson.zhai@spreadtrum.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH 1/2] arm64: dts: add Spreadtrum's fm support
Date: Tue, 4 Jul 2017 13:35:11 +0100 [thread overview]
Message-ID: <20170704123510.GC21587@leverpostej> (raw)
In-Reply-To: <20170704101508.30946-2-chunyan.zhang@spreadtrum.com>
On Tue, Jul 04, 2017 at 06:15:07PM +0800, Chunyan Zhang wrote:
> Added FM support for Spreadtrum's SP9860 board.
>
> Signed-off-by: Songhe Wei <songhe.wei@spreadtrum.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
> ---
> arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> index 0362ecd..6fe052d 100644
> --- a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> @@ -39,6 +39,10 @@
> #size-cells = <2>;
> ranges;
> };
> +
> + sprd-fm {
> + compatible = "sprd,marlin2-fm";
> + };
What kind of device is this? MMIO?
It seems to be sitting directly under the root node, but has no reg or
relationship with another bus defined, so something is missing.
This will need binding documentation.
Thanks,
Mark.
> };
>
> &uart0 {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-04 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 10:15 [PATCH 0/2] add support for Spreadtrum's FM driver Chunyan Zhang
2017-07-04 10:15 ` [PATCH 1/2] arm64: dts: add Spreadtrum's fm support Chunyan Zhang
2017-07-04 12:35 ` Mark Rutland [this message]
2017-07-04 10:15 ` [PATCH 2/2] misc: added Spreadtrum's radio driver Chunyan Zhang
2017-07-04 10:51 ` Arnd Bergmann
2017-07-05 10:18 ` Chunyan Zhang
2017-07-05 11:43 ` Arnd Bergmann
2017-07-05 10:25 ` [PATCH 0/2] add support for Spreadtrum's FM driver Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704123510.GC21587@leverpostej \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=chunyan.zhang@spreadtrum.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orson.zhai@spreadtrum.com \
--cc=songhe.wei@spreadtrum.com \
--cc=zhang.lyra@gmail.com \
--cc=zhongping.tan@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).