From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Yong <yong.deng@magewell.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
wens@csie.org, hans.verkuil@cisco.com, peter.griffin@linaro.org,
hugues.fruchet@st.com, krzk@kernel.org, bparrot@ti.com,
arnd@arndb.de, jean-christophe.trotin@st.com,
benjamin.gaignard@linaro.org, tiffany.lin@mediatek.com,
kamil@wypas.org, kieran+renesas@ksquared.org.uk,
andrew-ct.chen@mediatek.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.
Date: Tue, 4 Jul 2017 22:17:55 +0200 [thread overview]
Message-ID: <20170704201755.fuktyr2nyrhvndas@flea> (raw)
In-Reply-To: <20170704152545.4a70f04db2c984d4d54bf9dd@magewell.com>
[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]
On Tue, Jul 04, 2017 at 03:25:45PM +0800, Yong wrote:
> On Mon, 3 Jul 2017 13:25:21 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > Hi,
> >
> > On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote:
> > > > > + select VIDEOBUF2_DMA_CONTIG
> > > > > + select REGMAP_MMIO
> > > > > + ---help---
> > > > > + Support for the Allwinner Camera Sensor Interface Controller.
> > > >
> > > > This controller is the same for all Allwinner SoC models?
> > >
> > > No.
> > > I will change the Kconfig and Makefile.
> >
> > This is basically a design that has been introduced in the A31 (sun6i
> > family). I guess we should just call the driver and Kconfig symbols
> > sun6i_csi (even though we don't support it yet). It also used on the
> > A23, A33, A80, A83T, H3, and probably the H5 and A64.
>
> Thanks for the advice. That's good.
> My purpose is to make the code reusable. People working on other
> Allwinner SoC could easily make their CSI working by just filling the
> SoC specific code. But I'm not familiar with other Allwinner SoCs
> except V3s. I hope to get more advice.
Right, of course we don't expect you to do all that work, and we
should definitely focus on the V3s that you have for now. My comment
was only about the driver name and Kconfig option.
For the rest of the code, see the other comments :)
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-07-04 20:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 11:07 [PATCH RFC 0/2] Initial Allwinner V3s CSI Support Yong Deng
2017-06-27 11:07 ` [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI Yong Deng
2017-07-03 10:18 ` Hans Verkuil
2017-07-03 10:59 ` Yong
2017-07-03 11:25 ` Maxime Ripard
2017-07-04 7:25 ` Yong
2017-07-04 20:17 ` Maxime Ripard [this message]
2017-06-27 11:07 ` [PATCH RFC 2/2] dt-bindings: add binding documentation " Yong Deng
2017-06-29 21:19 ` Rob Herring
2017-06-30 3:41 ` Chen-Yu Tsai
2017-06-30 7:55 ` Yong
2017-06-30 16:05 ` Rob Herring
2017-07-18 11:55 ` Baruch Siach
2017-07-19 1:22 ` Yong
2017-07-19 4:49 ` Baruch Siach
2017-07-19 6:21 ` Yong
2017-07-19 6:33 ` Baruch Siach
2017-07-19 6:50 ` Maxime Ripard
2017-07-19 7:00 ` Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704201755.fuktyr2nyrhvndas@flea \
--to=maxime.ripard@free-electrons.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=jean-christophe.trotin@st.com \
--cc=kamil@wypas.org \
--cc=kieran+renesas@ksquared.org.uk \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).