From: Bjorn Helgaas <helgaas@kernel.org>
To: Mason <slash.tmp@free.fr>
Cc: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-pci <linux-pci@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
DT <devicetree@vger.kernel.org>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>
Subject: Re: [PATCH v9 0/3] Tango PCIe controller support
Date: Wed, 5 Jul 2017 13:03:59 -0500 [thread overview]
Message-ID: <20170705180359.GL13824@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <6256cab3-dd77-c0f6-66b8-be261695bbb1@free.fr>
On Wed, Jul 05, 2017 at 12:55:37AM +0200, Mason wrote:
> On 04/07/2017 22:24, Bjorn Helgaas wrote:
>
> > On Tue, Jun 20, 2017 at 10:12:57AM +0200, Marc Gonzalez wrote:
> >
> >> Marc Z pointed out that posting partial series is not ideal.
> >> Collect last-minute fixups into a single patch series.
> >>
> >> - Bump series to v9 to avoid any ambiguity
> >> - Add Rob's Ack on patch 1
> >>
> >> Marc Gonzalez (3):
> >> PCI: Add DT binding for tango PCIe controller
> >> PCI: Add tango PCIe host bridge support
> >> PCI: Add tango MSI controller support
> >>
> >> .../devicetree/bindings/pci/tango-pcie.txt | 29 ++
> >> drivers/pci/host/Kconfig | 8 +
> >> drivers/pci/host/Makefile | 1 +
> >> drivers/pci/host/pcie-tango.c | 390 +++++++++++++++++++++
> >> include/linux/pci_ids.h | 2 +
> >> 5 files changed, 430 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/pci/tango-pcie.txt
> >> create mode 100644 drivers/pci/host/pcie-tango.c
> >
> > I made the trivial changes I mentioned, added a dependency on
> > CONFIG_BROKEN (for the config/MMIO muxing issue), and put these on
> > pci/host-tango. I can't build or test this, so I probably broke
> > something in the process. I think the combination of the boot-time
> > warning, the taint, and CONFIG_BROKEN is a reasonable amount of
> > warning that a user should expect issues.
> >
> > Can you take a look and see if it works for you?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-tango
>
> Thanks. I'll take it for a spin ASAP.
>
> TAINT_CRAP... Smirk. I didn't see that one in the docs:
> https://www.kernel.org/doc/html/latest/admin-guide/tainted-kernels.html
>
> Oh wait... TAINT_CRAP is "C" => a staging driver has been loaded
I wish it had a less pejorative, more descriptive name. But it seems like
the closest to this situation.
> The one issue I anticipate with "depends on BROKEN" is
> when I add support for revision 2, which isn't broken.
How about this:
- Rename PCIE_TANGO to PCIE_TANGO_REV1
- PCIE_TANGO_REV1 depends on BROKEN
- Add rev2 support later, enabled by PCIE_TANGO
- PCIE_TANGO_REV1 depends on PCIE_TANGO && BROKEN
I updated pci/host-tango along these lines (without rev2 support,
obviously).
I forgot to ask for a MAINTAINERS update. Can you send that, too,
please?
Which reminds me -- are these two addreses
Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Mason <slash.tmp@free.fr>
different names for the same person? Conversations are easier for me
if I can keep who's who straight :)
Bjorn
next prev parent reply other threads:[~2017-07-05 18:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 8:12 [PATCH v9 0/3] Tango PCIe controller support Marc Gonzalez
2017-06-20 8:14 ` [PATCH v9 1/3] PCI: Add DT binding for tango PCIe controller Marc Gonzalez
2017-06-20 8:17 ` [PATCH v9 2/3] PCI: Add tango PCIe host bridge support Marc Gonzalez
2017-07-02 23:18 ` Bjorn Helgaas
2017-07-03 9:35 ` Ard Biesheuvel
2017-07-03 13:27 ` Bjorn Helgaas
2017-07-04 6:58 ` Jisheng Zhang
2017-07-04 7:16 ` Jisheng Zhang
2017-07-04 8:02 ` Ard Biesheuvel
2017-07-04 8:19 ` Jisheng Zhang
2017-07-04 9:38 ` Ard Biesheuvel
2017-07-05 13:53 ` Joao Pinto
2017-07-03 9:54 ` Marc Gonzalez
2017-07-03 13:13 ` Marc Gonzalez
2017-07-03 15:30 ` Marc Gonzalez
2017-07-04 7:09 ` Peter Zijlstra
2017-07-04 13:08 ` Mason
2017-07-04 14:27 ` Peter Zijlstra
2017-07-04 15:18 ` Mason
2017-07-03 13:40 ` Bjorn Helgaas
2017-07-03 14:34 ` Marc Gonzalez
2017-07-04 15:58 ` Bjorn Helgaas
2017-07-04 23:42 ` Mason
2017-07-03 18:11 ` Russell King - ARM Linux
2017-07-03 18:44 ` Ard Biesheuvel
2017-07-04 15:15 ` Bjorn Helgaas
2017-07-04 18:17 ` Russell King - ARM Linux
2017-07-04 23:59 ` Mason
2017-07-05 5:21 ` Greg Kroah-Hartman
2017-07-05 12:33 ` Mark Brown
2017-06-20 8:18 ` [PATCH v9 3/3] PCI: Add tango MSI controller support Marc Gonzalez
2017-07-04 20:24 ` [PATCH v9 0/3] Tango PCIe " Bjorn Helgaas
2017-07-04 22:55 ` Mason
2017-07-05 18:03 ` Bjorn Helgaas [this message]
2017-07-05 20:39 ` Mason
2017-07-05 21:34 ` Bjorn Helgaas
2017-07-05 21:59 ` Mason
2017-07-06 3:39 ` Bjorn Helgaas
2017-07-06 12:26 ` Mason
2017-07-06 12:40 ` Marc Zyngier
2017-07-06 19:46 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705180359.GL13824@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=slash.tmp@free.fr \
--cc=tglx@linutronix.de \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).