From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: William Koh <kkc6196@fb.com>, Andreas Dilger <adilger@dilger.ca>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-ext4 <linux-ext4@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
xfs <linux-xfs@vger.kernel.org>,
neilb@suse.com
Subject: Re: [PATCH] fs: ext4: inode->i_generation not assigned 0.
Date: Wed, 5 Jul 2017 16:49:28 -0400 [thread overview]
Message-ID: <20170705204928.GA8151@fieldses.org> (raw)
In-Reply-To: <20170705191933.GA6297@magnolia>
On Wed, Jul 05, 2017 at 12:19:33PM -0700, Darrick J. Wong wrote:
> On Tue, Jul 04, 2017 at 09:15:34PM -0400, J. Bruce Fields wrote:
> > On Mon, Jul 03, 2017 at 09:04:46PM -0700, Darrick J. Wong wrote:
> > > On Thu, Jun 29, 2017 at 02:50:22PM -0400, J. Bruce Fields wrote:
> > > > On Thu, Jun 29, 2017 at 02:30:53PM -0400, J. Bruce Fields wrote:
> > > > > On Thu, Jun 29, 2017 at 10:25:28AM -0700, Darrick J. Wong wrote:
> > > > > > Was there ever a version of NFS (or more generally callers of the
> > > > > > exportfs code) that couldn't deal with i_generation in the file handle,
> > > > > > and therefore we invented this generation hack to work around the loss
> > > > > > of the generation information?
> > > > > >
> > > > > > There's a comment in xfs_fs_encode_fh about not supporting 64bit inodes
> > > > > > with subtree_check (which seems to require one ino/gen pair for the file
> > > > > > and a second pair for the file's parent) on NFSv2 because v2 doesn't
> > > > > > provide enough space for all the file handle information, but that's the
> > > > > > furthest I got with lazy-mining the git history. :)
> > > > >
> > > > > There's a comment in fs/ext4/super.c:ext4_nfs_get_inode
> > > > >
> > > > > * Currently we don't know the generation for parent directory, so
> > > > > * a generation of 0 means "accept any"
> > > > >
> > > > > But I don't see that used.
> > > > >
> > > > > It was used once upon a time; I see it actually used in old 2.5 code in
> > > > > nfsd_get_dentry. Hm.
> > > >
> > > > Oh, maybe it's here in fs/libfs.c:generic_fh_to_parent:
> > > >
> > > > switch (fh_type) {
> > > > case FILEID_INO32_GEN_PARENT:
> > > > inode = get_inode(sb, fid->i32.parent_ino,
> > > > (fh_len > 3 ? fid->i32.parent_gen : 0));
> > > > break;
> > > > }
> > > >
> > > > I'm not sure under what conditions that filehandle encoding is used.
> > >
> > > The best guess I can come up with is the old nfs_fhbase_old style handles,
> > > which (afaict) do not carry parent i_generation?
> >
> > Yeah, I just couldn't tell in the time I looked whether they could still
> > be handed out.
> >
> > If not, then the only way they'd still be used is if a client had a
> > server continually mounted while the server was upgraded from a kernel
> > that still handed out the old filehandle.
> >
> > So if they haven't been given out for long enough it's possible nobody
> > would notice if we dropped support.
> >
> > But, I didn't get far enough to figure that out.
>
> Hmm, so looking back through prehistory, Linux prior to 2.3.51 (11 March
> 2000) gave out the old dentry style fhandles. After that, the kernel
> only gave out the new style handles that we still use today. In 2.4.6
> (4 July 2001) the behavior was modified again to chain handle types,
> i.e. if the client passed in an old style handle then it would get
> another old style handle back. The changelog for -pre9 says that this
> was done for compatibility reasons.
Yeah, you're supposed to be able to reboot your NFS server for a kernel
upgrade without your client applications experiencing anything worse
than a temporary hang while you wait for the server to come back up.
So, changing the filehandle format and returning ESTALE to everyone
would be unpopular.
> So, what's the probability that there are clients out there that started
> talking to a 2.2-based knfsd and will now want to talk to a modern 4.13
> kernel seventeen years later?
I think it's unlikely enough that we could drop that code; cc'ing Neil
in case we overlooked anything.
> (Do nfs handles persist across client restarts/remounts?)
No.
(Well, with maybe a couple exceptions (fscache and persistent NFSv4
delegations) but neither seem relevant here.)
--b.
next prev parent reply other threads:[~2017-07-05 20:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 22:06 [PATCH] fs: ext4: inode->i_generation not assigned 0 Kyungchan Koh
2017-06-29 0:48 ` Darrick J. Wong
2017-06-29 0:58 ` William Koh
2017-06-29 2:32 ` Andreas Dilger
2017-06-29 4:37 ` William Koh
2017-06-29 4:59 ` Darrick J. Wong
2017-06-29 14:28 ` William Koh
2017-06-29 14:35 ` J. Bruce Fields
2017-06-29 17:25 ` Darrick J. Wong
2017-06-29 18:30 ` J. Bruce Fields
2017-06-29 18:50 ` J. Bruce Fields
2017-07-04 4:04 ` Darrick J. Wong
2017-07-05 1:15 ` J. Bruce Fields
2017-07-05 19:19 ` Darrick J. Wong
2017-07-05 20:27 ` Theodore Ts'o
2017-07-07 10:51 ` Jeff Layton
2017-07-07 15:51 ` Theodore Ts'o
2017-07-07 16:13 ` Jeff Layton
2017-07-07 16:47 ` J. Bruce Fields
2017-07-05 20:49 ` J. Bruce Fields [this message]
2017-07-06 1:08 ` NeilBrown
2017-07-06 2:39 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705204928.GA8151@fieldses.org \
--to=bfields@fieldses.org \
--cc=Kernel-team@fb.com \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=kkc6196@fb.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=trond.myklebust@primarydata.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).