From: Jeff Layton <jlayton@kernel.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: [PATCH] integrity: get rid of unneeded initializations in integrity_iint_cache entries
Date: Thu, 6 Jul 2017 10:54:21 -0400 [thread overview]
Message-ID: <20170706145421.13223-1-jlayton@kernel.org> (raw)
From: Jeff Layton <jlayton@redhat.com>
The init_once routine memsets the whole object to 0, and then
explicitly sets some of the fields to 0 again. Just remove the explicit
initializations.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
security/integrity/iint.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/security/integrity/iint.c b/security/integrity/iint.c
index 6fc888ca468e..187b7cb378be 100644
--- a/security/integrity/iint.c
+++ b/security/integrity/iint.c
@@ -153,14 +153,11 @@ static void init_once(void *foo)
struct integrity_iint_cache *iint = foo;
memset(iint, 0, sizeof(*iint));
- iint->version = 0;
- iint->flags = 0UL;
iint->ima_file_status = INTEGRITY_UNKNOWN;
iint->ima_mmap_status = INTEGRITY_UNKNOWN;
iint->ima_bprm_status = INTEGRITY_UNKNOWN;
iint->ima_read_status = INTEGRITY_UNKNOWN;
iint->evm_status = INTEGRITY_UNKNOWN;
- iint->measured_pcrs = 0;
}
static int __init integrity_iintcache_init(void)
--
2.13.0
next reply other threads:[~2017-07-06 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 14:54 Jeff Layton [this message]
2017-07-06 15:04 ` [PATCH] integrity: get rid of unneeded initializations in integrity_iint_cache entries Serge E. Hallyn
2017-07-06 19:43 ` Mimi Zohar
2017-12-07 12:01 ` Jeff Layton
2017-12-07 14:35 ` Mimi Zohar
2017-12-07 15:16 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706145421.13223-1-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).