From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbdGFQEO (ORCPT ); Thu, 6 Jul 2017 12:04:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbdGFQEM (ORCPT ); Thu, 6 Jul 2017 12:04:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6CCE0C04D2E4 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6CCE0C04D2E4 Date: Thu, 6 Jul 2017 18:04:10 +0200 From: Jiri Olsa To: changbin.du@intel.com Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] perf sort: only insert overhead && overhead_children when no overhead* field given Message-ID: <20170706160410.GA3227@krava> References: <1496307801-24134-1-git-send-email-changbin.du@intel.com> <1499225752-2959-1-git-send-email-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499225752-2959-1-git-send-email-changbin.du@intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 06 Jul 2017 16:04:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 05, 2017 at 11:35:52AM +0800, changbin.du@intel.com wrote: > From: Changbin Du > > If we always insert 'overhead' and 'overhead_children' as sort keys, > this make it impossible to sort as overhead (which displayed as Self) > first.Ths will be a problem if the data is collected with call-graph > enabled. Then we never can sort the result as self-overhead on this > data. And sometimes the data is hard to collect. > > > perf record -ag > > perf report -s overhead,sym > > Samples: 7K of event 'cycles', Event count (approx.): 865138253 > Children Self Symbol > + 26.41% 0.00% [k] verify_cpu > + 26.37% 0.04% [k] cpu_startup_entry > + 25.93% 0.27% [k] do_idle > + 19.88% 0.00% [k] start_secondary > .... > > I intend to sort as 'Self', but actually it sort as 'Children'. > > This patch fix this by only insert overhead && overhead_children > when no overhead* field given. > > Signed-off-by: Changbin Du Acked-by: Jiri Olsa thanks, jirka > --- > v3: Add comment in code from Jiri > v2: Add the example in commit message. > > --- > tools/perf/util/sort.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index 8b327c9..9e087fb 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -2635,6 +2635,13 @@ static char *setup_overhead(char *keys) > if (sort__mode == SORT_MODE__DIFF) > return keys; > > + /** > + * User already stated overhead within -s option, > + * do not mangle with that. > + */ > + if (strstr(keys, "overhead")) > + return keys; > + > keys = prefix_if_not_in("overhead", keys); > > if (symbol_conf.cumulate_callchain) > -- > 2.7.4 >