From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbdGFWdq (ORCPT ); Thu, 6 Jul 2017 18:33:46 -0400 Received: from mga04.intel.com ([192.55.52.120]:26584 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbdGFWdo (ORCPT ); Thu, 6 Jul 2017 18:33:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,319,1496127600"; d="scan'208";a="1169445086" Date: Thu, 6 Jul 2017 18:39:56 -0400 From: Keith Busch To: Christoph Hellwig Cc: David Wayne Fugate , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NVMe: Added another device ID with stripe quirk Message-ID: <20170706223955.GA1200@localhost.localdomain> References: <1499379151-32479-1-git-send-email-david.fugate@intel.com> <20170706221754.GA10217@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170706221754.GA10217@lst.de> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 07, 2017 at 12:17:54AM +0200, Christoph Hellwig wrote: > On Thu, Jul 06, 2017 at 04:12:31PM -0600, David Wayne Fugate wrote: > > Adds a fourth Intel controller which has the "stripe" quirk. > > NVMe has stadardized a way to communicate this information through > the Namespace Optimal IO Boundary (NOIOB) field in the Identify > Namespace structure, and Keith and Amber at Intel helped to define > this, so please actually implement it in your controllers. That's true for all Intel controllers going forward, but this is actually an older controller that pre-dates NOIOB. It's the exact same as the 8086:0A54 model, but a particular vendor decided their rebranded device needs to be made special with a different DID. We all agree that's a terrible way to go about this for mutliple reasons, but we can't go back in time to tell the decision makers of this folly. So I think we need to let this last one go through with the quirk. Acked-by: Keith Busch