From: Viresh Kumar <viresh.kumar@linaro.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: peterz@infradead.org, mingo@redhat.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
tglx@linutronix.de, vincent.guittot@linaro.org,
rostedt@goodmis.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
tkjos@android.com, joelaf@google.com, andresoportus@google.com,
morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
patrick.bellasi@arm.com, Ingo Molnar <mingo@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [RFC PATCH v1 5/8] sched/cpufreq_schedutil: always consider all CPUs when deciding next freq
Date: Fri, 7 Jul 2017 14:29:11 +0530 [thread overview]
Message-ID: <20170707085911.GB32542@vireshk-i7> (raw)
In-Reply-To: <20170705085905.6558-6-juri.lelli@arm.com>
On 05-07-17, 09:59, Juri Lelli wrote:
> No assumption can be made upon the rate at which frequency updates get
> triggered, as there are scheduling policies (like SCHED_DEADLINE) which
> don't trigger them so frequently.
>
> Remove such assumption from the code, by always considering
> SCHED_DEADLINE utilization signal as not stale.
>
> Signed-off-by: Juri Lelli <juri.lelli@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Luca Abeni <luca.abeni@santannapisa.it>
> Cc: Claudio Scordino <claudio@evidence.eu.com>
> ---
> kernel/sched/cpufreq_schedutil.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index e835fa886225..066b876d81e7 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -267,17 +267,22 @@ static unsigned int sugov_next_freq_shared(struct sugov_cpu *sg_cpu, u64 time)
> s64 delta_ns;
>
> /*
> - * If the CPU utilization was last updated before the previous
> - * frequency update and the time elapsed between the last update
> - * of the CPU utilization and the last frequency update is long
> - * enough, don't take the CPU into account as it probably is
> - * idle now (and clear iowait_boost for it).
> + * If the CFS CPU utilization was last updated before the
> + * previous frequency update and the time elapsed between the
> + * last update of the CPU utilization and the last frequency
> + * update is long enough, reset iowait_boost and util_cfs, as
> + * they are now probably stale. However, still consider the
> + * CPU contribution if it has some DEADLINE utilization
> + * (util_dl).
> */
> delta_ns = time - j_sg_cpu->last_update;
> if (delta_ns > TICK_NSEC) {
> j_sg_cpu->iowait_boost = 0;
> - continue;
> + j_sg_cpu->util_cfs = 0;
> + if (j_sg_cpu->util_dl == 0)
> + continue;
> }
> +
> if (j_sg_cpu->flags & SCHED_CPUFREQ_RT)
> return policy->cpuinfo.max_freq;
>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2017-07-07 8:59 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 8:58 [RFC PATCH v1 0/8] SCHED_DEADLINE freq/cpu invariance and OPP selection Juri Lelli
2017-07-05 8:58 ` [RFC PATCH v1 1/8] sched/cpufreq_schedutil: make use of DEADLINE utilization signal Juri Lelli
2017-07-07 7:20 ` Viresh Kumar
2017-07-05 8:58 ` [RFC PATCH v1 2/8] sched/deadline: move cpu frequency selection triggering points Juri Lelli
2017-07-07 7:21 ` Viresh Kumar
2017-07-05 8:59 ` [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE Juri Lelli
2017-07-07 3:56 ` Joel Fernandes
2017-07-07 10:43 ` Juri Lelli
2017-07-07 10:46 ` Thomas Gleixner
2017-07-07 10:53 ` Juri Lelli
2017-07-07 13:11 ` Rafael J. Wysocki
2017-07-07 21:58 ` Steven Rostedt
2017-07-07 22:07 ` Joel Fernandes
2017-07-07 22:15 ` Steven Rostedt
2017-07-07 22:57 ` Joel Fernandes
2017-07-11 12:37 ` Peter Zijlstra
2017-07-07 7:21 ` Viresh Kumar
2017-07-11 16:18 ` Peter Zijlstra
2017-07-11 17:02 ` Juri Lelli
2017-07-05 8:59 ` [RFC PATCH v1 4/8] sched/cpufreq_schedutil: split utilization signals Juri Lelli
2017-07-07 3:26 ` Joel Fernandes
2017-07-07 8:58 ` Viresh Kumar
2017-07-07 10:59 ` Juri Lelli
2017-07-10 7:46 ` Joel Fernandes
2017-07-10 7:05 ` Viresh Kumar
2017-07-05 8:59 ` [RFC PATCH v1 5/8] sched/cpufreq_schedutil: always consider all CPUs when deciding next freq Juri Lelli
2017-07-07 8:59 ` Viresh Kumar [this message]
2017-07-11 16:17 ` Peter Zijlstra
2017-07-11 17:18 ` Juri Lelli
2017-07-05 8:59 ` [RFC PATCH v1 6/8] sched/sched.h: remove sd arch_scale_freq_capacity parameter Juri Lelli
2017-07-05 8:59 ` [RFC PATCH v1 7/8] sched/sched.h: move arch_scale_{freq,cpu}_capacity outside CONFIG_SMP Juri Lelli
2017-07-07 22:04 ` Steven Rostedt
2017-07-05 8:59 ` [RFC PATCH v1 8/8] sched/deadline: make bandwidth enforcement scale-invariant Juri Lelli
2017-07-19 7:21 ` Peter Zijlstra
2017-07-19 9:20 ` Juri Lelli
2017-07-19 11:00 ` Peter Zijlstra
2017-07-19 11:16 ` Juri Lelli
2017-07-24 16:43 ` Peter Zijlstra
2017-07-25 7:03 ` Luca Abeni
2017-07-25 13:51 ` Peter Zijlstra
2017-07-26 13:50 ` luca abeni
2017-07-06 15:57 ` [RFC PATCH v1 0/8] SCHED_DEADLINE freq/cpu invariance and OPP selection Steven Rostedt
2017-07-06 16:08 ` Juri Lelli
2017-07-06 16:15 ` Peter Zijlstra
2017-07-06 21:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707085911.GB32542@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andresoportus@google.com \
--cc=bristot@redhat.com \
--cc=claudio@evidence.eu.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tkjos@android.com \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).