From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
devicetree@vger.kernel.org, mark.rutland@arm.com,
bradleyb@fuzziesquirrel.com, jk@ozlabs.org,
cbostic@linux.vnet.ibm.com, joel@jms.id.au, andrew@aj.id.au,
"Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH v2 5/5] Documentation/devicetree/bindings: Add FSI device documentation
Date: Sun, 9 Jul 2017 20:24:13 -0500 [thread overview]
Message-ID: <20170710012413.g3jhgby6x3m2eznx@rob-hp-laptop> (raw)
In-Reply-To: <1499290617-2598-6-git-send-email-eajames@linux.vnet.ibm.com>
On Wed, Jul 05, 2017 at 04:36:57PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
"dt-bindings: fsi: ..." for the subject.
>
> Document the bindings for the SBE and OCC devices. SBE devices are
> located on a CFAM on an FSI bus, and OCC devices are accessed through
> the SBEFIFO.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
> Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt | 15 +++++++++++++++
> .../devicetree/bindings/fsi/ibm,p9-sbefifo.txt | 20 ++++++++++++++++++++
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
>
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> new file mode 100644
> index 0000000..766b706
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> @@ -0,0 +1,15 @@
> +Device-tree bindings for FSI-based On-Chip Controller driver
> +------------------------------------------------------------
Bindings are for h/w, not drivers.
> +
> +Required properties:
> + - compatible = "ibm,p9-occ";
> +
> +Optional properties:
> + - reg = <processor index>; : Index for the processor this OCC is on.
> +
> +Examples:
> +
> + occ@1 {
> + compatible = "ibm,p9-occ";
> + reg = <1>;
> + };
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> new file mode 100644
> index 0000000..d16ab9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> @@ -0,0 +1,20 @@
> +Device-tree bindings for FSI-based SBEFIFO driver
> +-------------------------------------------------
Bindings are for h/w, not drivers.
> +
> +Required properties:
> + - reg = < address size > : FSI CFAM address for the SBE engine
> + and address space size.
> +
> +Optional properties:
> + - <child nodes> : Devices that are accessible through
> + the SBEFIFO.
> +
> +Examples:
> +
> + sbefifo@2400 {
This should have a compatible.
> + reg = < 0x2400 0x400 >;
> +
> + occ@1 {
> + ...
> + };
> + };
> --
> 1.8.3.1
>
prev parent reply other threads:[~2017-07-10 1:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 21:36 [PATCH v2 0/5] drivers/fsi: Add SBEFIFO and OCC drivers Eddie James
2017-07-05 21:36 ` [PATCH v2 1/5] drivers/fsi: Add SBEFIFO FSI client device driver Eddie James
2017-07-05 21:36 ` [PATCH v2 2/5] drivers/fsi/sbefifo: Add in-kernel API Eddie James
2017-07-12 17:24 ` kbuild test robot
2017-07-05 21:36 ` [PATCH v2 3/5] drivers/fsi: Add On-Chip Controller (OCC) driver Eddie James
2017-07-05 21:36 ` [PATCH v2 4/5] drivers/fsi/occ: Add in-kernel API Eddie James
2017-07-05 21:36 ` [PATCH v2 5/5] Documentation/devicetree/bindings: Add FSI device documentation Eddie James
2017-07-10 1:24 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710012413.g3jhgby6x3m2eznx@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=bradleyb@fuzziesquirrel.com \
--cc=cbostic@linux.vnet.ibm.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=eajames@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).