From: Rob Herring <robh@kernel.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: mark.rutland@arm.com, nsekhar@ti.com, david@lechnology.com,
wsa@the-dreams.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
nicolas.ferre@microchip.com, ludovic.desroches@microchip.com
Subject: Re: [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding
Date: Sun, 9 Jul 2017 22:46:13 -0500 [thread overview]
Message-ID: <20170710034613.fc4vj6h22kagce24@rob-hp-laptop> (raw)
In-Reply-To: <1499336217-16913-4-git-send-email-claudiu.beznea@microchip.com>
On Thu, Jul 06, 2017 at 01:16:57PM +0300, Claudiu Beznea wrote:
> Document "mac-offset" binding that will be used by at24 EEPROM driver.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index a50dc01..3dd267c 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -35,10 +35,13 @@ Optional properties:
>
> - read-only: this parameterless property disables writes to the eeprom
>
> + - mac-offset: offset in EEPROM where MAC address starts
> +
This doesn't scale if you have multiple things you need the offset to,
and we already have a binding for this. Use the nvmem binding.
Rob
next prev parent reply other threads:[~2017-07-10 3:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 10:16 [PATCH 0/3] Add at24 functionality to read MAC form different EEPROM offsets Claudiu Beznea
2017-07-06 10:16 ` [PATCH 1/3] dt-bindings: i2c: eeprom: document all at24 bindings Claudiu Beznea
2017-07-10 3:44 ` Rob Herring
2017-07-06 10:16 ` [PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses Claudiu Beznea
2017-07-06 10:16 ` [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding Claudiu Beznea
2017-07-10 3:46 ` Rob Herring [this message]
2017-07-19 9:08 ` m18063
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710034613.fc4vj6h22kagce24@rob-hp-laptop \
--to=robh@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsekhar@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).