From: Sam Ravnborg <sam@ravnborg.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/28] kbuild: complete UAPI de-coupling and cleanup scripts/Makefile.headersinst
Date: Mon, 10 Jul 2017 10:42:08 +0200 [thread overview]
Message-ID: <20170710084208.GA25874@ravnborg.org> (raw)
In-Reply-To: <1499625180-8067-1-git-send-email-yamada.masahiro@socionext.com>
Hi Masahiro.
On Mon, Jul 10, 2017 at 03:32:32AM +0900, Masahiro Yamada wrote:
> In v4.12-rc1, we had a big progress for headers_install.
> All (and only) headers under UAPI directories are exported.
> However, asm-generic wrappers are still exceptions because
> most of arch/*/include/asm/Kbuild include "generic-y" for
> exported headers. As a result, many of generic-wrappers to be
> exported are generated outside UAPI directories.
>
> To finish de-coupling UAPI, "generic-y" for exported headers
> should be moved to arch/*/include/uapi/asm/Kbuild.
>
> With those cleanups, the logic of headers_install will become
> even simpler. UAPI will be completely self-contained.
>
> This series is based on:
> commit 19bf2e0ef18ec8a7284ecc83459a2664cb885cd5
>
> Changes for v2:
> - rebase on the latest in the mainline in order to avoid merge conflicts
Series looks good.
In several of your patches assignments are moved to the arch
specific uapi file, but the same assignment are already present in
include/uapi/asm-generic/Kbuild.asm so the assignment is redundant.
For example:
$ARCH uapi Kbuild:
generic-y += errno.h
uapi/asm-generic Kbuild:
mandatory-y += errno.h
As this patch-set is touching all arch files this
could be a good opportunity to clean this up too.
But maybe mandatory-y and generic-y do something different,
and both are needed. In wich cases all is good.
Sam
next prev parent reply other threads:[~2017-07-10 8:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 18:32 [PATCH v2 00/28] kbuild: complete UAPI de-coupling and cleanup scripts/Makefile.headersinst Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 01/28] kbuild: remove useless $(gen) variable in Makefile.headersinst Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 02/28] kbuild: fix comment about dst of headers_{install,check}_all Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 03/28] kbuild: pass dst= to Makefile.headersinst from top Makefile Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 04/28] arm64: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 05/28] ARM: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 06/28] arc: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 07/28] blackfin: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 08/28] c6x: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 09/28] cris: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 10/28] h8300: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 11/28] hexagon: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 12/28] ia64: remove redundant generic-y += kvm_para.h from asm/Kbuild Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 13/28] m32r: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 14/28] m68k: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 15/28] metag: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 16/28] microblaze: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 17/28] nios2: remove unneeded arch/nios2/include/(generated/)asm/signal.h Masahiro Yamada
2017-07-11 9:19 ` Tobias Klauser
2017-07-09 18:32 ` [PATCH v2 18/28] nios2: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada
2017-07-11 9:20 ` Tobias Klauser
2017-07-09 18:32 ` [PATCH v2 19/28] openrisc: " Masahiro Yamada
2017-07-10 20:21 ` Stafford Horne
2017-07-09 18:32 ` [PATCH v2 20/28] parisc: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 21/28] sh: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 22/28] sparc: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 23/28] tile: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 24/28] unicore32: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 25/28] xtensa: " Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 26/28] kbuild: do not include old-kbuild-file from Makefile.headersinst Masahiro Yamada
2017-07-09 18:32 ` [PATCH v2 27/28] kbuild: split exported generic header creation into uapi-asm-generic Masahiro Yamada
2017-07-09 18:33 ` [PATCH v2 28/28] kbuild: remove wrapper files handling from Makefile.headersinst Masahiro Yamada
2017-07-10 8:42 ` Sam Ravnborg [this message]
2017-07-10 9:12 ` [PATCH v2 00/28] kbuild: complete UAPI de-coupling and cleanup scripts/Makefile.headersinst Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710084208.GA25874@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).