From: Viresh Kumar <viresh.kumar@linaro.org>
To: Mitchell Tasman <tasman@leaflabs.com>
Cc: Vaibhav Hiremath <hvaibhav.linux@gmail.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosfl.org
Subject: Re: [greybus-dev] [PATCH v3] staging: greybus: arche: wrap over-length lines
Date: Tue, 11 Jul 2017 08:52:09 +0530 [thread overview]
Message-ID: <20170711032209.GK2928@vireshk-i7> (raw)
In-Reply-To: <20170711031444.1357-1-tasman@leaflabs.com>
On 10-07-17, 23:14, Mitchell Tasman wrote:
> Adjust formatting of several comments to keep line length within
> the 80 column limit preferred by the Linux kernel coding style.
>
> Signed-off-by: Mitchell Tasman <tasman@leaflabs.com>
> ---
> Changes in v3: Narrow scope of patch per Viresh Kumar's feedback
> Changes in v2: Add back a missing space in a comment
>
> drivers/staging/greybus/arche-platform.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index eced2d2..6259904 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -176,7 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> arche_platform_set_wake_detect_state(arche_pdata,
> WD_STATE_IDLE);
> } else {
> - /* Check we are not in middle of irq thread already */
> + /*
> + * Check we are not in middle of irq thread
> + * already
> + */
> if (arche_pdata->wake_detect_state !=
> WD_STATE_COLDBOOT_START) {
> arche_platform_set_wake_detect_state(arche_pdata,
> @@ -657,12 +660,14 @@ static SIMPLE_DEV_PM_OPS(arche_platform_pm_ops,
> arche_platform_resume);
>
> static const struct of_device_id arche_platform_of_match[] = {
> - { .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
> + /* Use PID/VID of SVC device */
> + { .compatible = "google,arche-platform", },
> { },
> };
>
> static const struct of_device_id arche_combined_id[] = {
> - { .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
> + /* Use PID/VID of SVC device */
> + { .compatible = "google,arche-platform", },
> { .compatible = "usbffff,2", },
> { },
> };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2017-07-11 3:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 21:28 [PATCH] staging: greybus: arche: wrap over-length lines Mitchell Tasman
2017-07-10 0:25 ` [PATCH v2] " Mitchell Tasman
2017-07-10 4:46 ` [greybus-dev] " Viresh Kumar
2017-07-10 9:30 ` Frans Klaver
2017-07-10 9:31 ` Viresh Kumar
2017-07-11 5:24 ` Joe Perches
2017-07-11 3:14 ` [PATCH v3] " Mitchell Tasman
2017-07-11 3:22 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711032209.GK2928@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devel@driverdev.osuosfl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hvaibhav.linux@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tasman@leaflabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).