From: Joerg Roedel <jroedel@suse.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Drake <drake@endlessm.com>,
Alexander Deucher <Alexander.Deucher@amd.com>,
Samuel Sieb <samuel@sieb.net>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs
Date: Tue, 11 Jul 2017 13:49:48 +0200 [thread overview]
Message-ID: <20170711114948.GA6244@suse.de> (raw)
In-Reply-To: <20170710165358.GD20365@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Mon, Jul 10, 2017 at 11:53:58AM -0500, Bjorn Helgaas wrote:
> I'm still confused. Per Samuel
> (6dd9dbac-9b65-bc7c-bb08-413a05d09fc8@sieb.net):
>
> Samuel> The other patch seems to fix this issue without disabling ATS.
> Samuel> Isn't that better?
>
> and Alex
> (BN6PR12MB1652DF4130FC792B71DD9974F7C00@BN6PR12MB1652.namprd12.prod.outlook.com):
>
> Alex> I talked to our validation team and ATS was validated on Stoney,
> Alex> so this patch is just working around something else. The other
> Alex> patch fixes it and is a valid optimization ...
>
> I'm confused about what this "other patch" is and whether we want that
> one, this one, or both.
The other patches floating around lowered the ATS flush-rate from the
AMD IOMMU driver, which makes the issue disappear as well. But the issue
only disappeared, it is not solved and could probably still be
reproduced with a GPU usage pattern that increases the ATS flush-rate.
So blacklisting the device for ATS is still the safest thing we could do
here.
Regards,
Joerg
next prev parent reply other threads:[~2017-07-11 11:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 14:32 [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Joerg Roedel
2017-04-07 16:46 ` Deucher, Alexander
2017-05-04 10:21 ` David Woodhouse
2017-05-04 14:41 ` Deucher, Alexander
2017-05-23 19:54 ` Deucher, Alexander
2017-05-24 8:44 ` Joerg Roedel
2017-05-24 10:38 ` David Woodhouse
2017-05-24 12:56 ` Deucher, Alexander
2017-05-26 6:48 ` Samuel Sieb
2017-05-26 11:57 ` Deucher, Alexander
2017-05-26 12:54 ` David Woodhouse
2017-05-26 15:59 ` Deucher, Alexander
2017-04-08 7:41 ` Lukas Wunner
2017-04-20 12:11 ` Joerg Roedel
2017-06-15 17:12 ` Bjorn Helgaas
2017-06-15 14:04 ` Joerg Roedel
2017-06-15 17:01 ` Samuel Sieb
2017-06-15 18:13 ` Deucher, Alexander
2017-06-15 19:15 ` Bjorn Helgaas
2017-06-16 16:29 ` Joerg Roedel
2017-07-10 16:53 ` Bjorn Helgaas
2017-07-11 11:49 ` Joerg Roedel [this message]
2017-07-11 19:08 ` Deucher, Alexander
2017-07-13 2:56 ` Bjorn Helgaas
2017-08-29 20:02 ` Samuel Sieb
2017-08-29 20:49 ` Bjorn Helgaas
2017-08-30 11:44 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711114948.GA6244@suse.de \
--to=jroedel@suse.de \
--cc=Alexander.Deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=drake@endlessm.com \
--cc=dwmw2@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=samuel@sieb.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).