From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel-dev@beckhoff.com
Cc: robh+dt@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de,
linux@armlinux.org.uk, fabio.estevam@nxp.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Patrick Brünn" <p.bruenn@beckhoff.com>
Subject: Re: [PATCH] ARM: dts: imx: add CX9020 Embedded PC device tree
Date: Wed, 12 Jul 2017 10:46:55 +0100 [thread overview]
Message-ID: <20170712094655.GC7472@leverpostej> (raw)
In-Reply-To: <20170712090408.12212-1-linux-kernel-dev@beckhoff.com>
Hi,
On Wed, Jul 12, 2017 at 11:04:08AM +0200, linux-kernel-dev@beckhoff.com wrote:
> +/dts-v1/;
> +#include "imx53.dtsi"
> +
> +#define MX53_PAD_EIM_D26__UART2_RXD_MUX 0x144 0x48c 0x880 0x2 0x0
> +#define MX53_PAD_EIM_D27__UART2_TXD_MUX 0x148 0x490 0x000 0x2 0x0
> +#define MX53_PAD_EIM_D28__UART2_RTS 0x14c 0x494 0x87c 0x2 0x0
> +#define MX53_PAD_EIM_D29__UART2_CTS 0x150 0x498 0x000 0x2 0x0
> +
> +/ {
> + model = "Freescale i.MX53 based Beckhoff CX9020";
> + compatible = "fsl,imx53-qsb", "fsl,imx53";
> +
> + chosen {
> + stdout-path = &uart2;
No baud-rate or bits configuration?
> + };
> +
> + memory {
> + reg = <0x70000000 0x20000000>,
> + <0xb0000000 0x20000000>;
> + };
> +
> + ccat {
> + compatible = "bhf,emi-ccat";
> + };
> +
> + display0: display@di0 {
This unit-address (the bit after the @) isn't valid, as that should
match a reg or ranges, but this node has neither.
Just call this display-0.
> + #address-cells =<1>;
> + #size-cells = <0>;
> + compatible = "fsl,imx-parallel-display";
> + interface-pix-fmt = "rgb24";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ipu_disp0>;
> + status = "okay";
> +
> + port@0 {
> + reg = <0>;
> + display0_in: endpoint {
> + remote-endpoint = <&ipu_di0_disp0>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + display0_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> +
> + dvi_panel: display@0 {
Likewise you have no reg here, so the unit address isn't valid.
Surely panel-0?
> + #address-cells =<1>;
> + #size-cells = <0>;
> + compatible = "simple,ddc-only";
I don't see that compatible string in my Linux tree, and it doesn't make
sense to me -- "simple" isn't a vendor-prefix.
Where has this come from?
> + ddc-i2c-bus = <&i2c2>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display0_out>;
> + };
> + };
> + };
[...]
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + reg_3p2v: regulator@0 {
> + compatible = "regulator-fixed";
> + reg = <0>;
Meaningless reg entry.
> + regulator-name = "3P2V";
> + regulator-min-microvolt = <3200000>;
> + regulator-max-microvolt = <3200000>;
> + regulator-always-on;
> + };
> +
> + reg_usb_vbus: regulator@1 {
> + compatible = "regulator-fixed";
> + reg = <1>;
Likewise.
> + regulator-name = "usb_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio7 8 0>;
> + enable-active-high;
> + };
> + };
There's no need for a simple-bus here. It doesn't represent HW, and you
can nothing. You can put these directly under the root node, without a
synthetic reg or unnecessary container:
reg_3p2v: regulator-3p2v {
compatible = "regulator-fixed";
regulator-name = "3P2V";
regulator-min-microvolt = <3200000>;
regulator-max-microvolt = <3200000>;
regulator-always-on;
};
reg_usb_vbus: regulator-usb-vbus {
compatible = "regulator-fixed";
regulator-name = "usb_vbus";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
gpio = <&gpio7 8 0>;
enable-active-high;
}
Otherwise, looks fine to me.
Thanks,
Mark.
next prev parent reply other threads:[~2017-07-12 9:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 9:04 [PATCH] ARM: dts: imx: add CX9020 Embedded PC device tree linux-kernel-dev
2017-07-12 9:46 ` Mark Rutland [this message]
2017-07-12 11:46 ` Patrick Brünn
2017-07-12 14:42 ` Andrew Lunn
2017-07-13 3:00 ` Patrick Brünn
2017-07-13 11:04 ` [PATCH v2 0/2] Add CX9020 " linux-kernel-dev
2017-07-13 11:04 ` [PATCH v2 1/2] ARM: dts: imx: add CX9020 Embedded PC " linux-kernel-dev
2017-07-13 11:04 ` [PATCH v2 2/2] drm/panel: simple: Add support for ddc-only panel linux-kernel-dev
2017-07-14 14:15 ` Rob Herring
2017-07-13 11:13 ` [PATCH v3 0/2] Add CX9020 device tree linux-kernel-dev
2017-07-13 11:13 ` [PATCH v3 1/2] ARM: dts: imx: add CX9020 Embedded PC " linux-kernel-dev
2017-07-14 2:16 ` Shawn Guo
2017-07-13 11:13 ` [PATCH v3 2/2] drm/panel: simple: Add support for ddc-only panel linux-kernel-dev
[not found] ` <20170721040640.31424-1-linux-kernel-dev@beckhoff.com>
2017-07-21 4:06 ` [PATCH v4 1/2] dt-bindings: arm: Add entry for Beckhoff CX9020 linux-kernel-dev
2017-07-24 20:28 ` Rob Herring
2017-07-21 4:06 ` [PATCH v4 2/2] ARM: dts: imx: add CX9020 Embedded PC device tree linux-kernel-dev
2017-07-25 7:59 ` Shawn Guo
2017-07-25 11:41 ` Patrick Brünn
2017-07-25 13:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712094655.GC7472@leverpostej \
--to=mark.rutland@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-dev@beckhoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=p.bruenn@beckhoff.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).