linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Gstir <david@sigma-star.at>
Cc: horia.geanta@nxp.com, dan.douglass@nxp.com, davem@davemloft.net,
	richard@sigma-star.at, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] crypto: caam - properly set IV after {en,de}crypt
Date: Wed, 12 Jul 2017 18:51:56 +0800	[thread overview]
Message-ID: <20170712105156.GC22109@gondor.apana.org.au> (raw)
In-Reply-To: <20170628132710.97278-1-david@sigma-star.at>

On Wed, Jun 28, 2017 at 03:27:10PM +0200, David Gstir wrote:
> Certain cipher modes like CTS expect the IV (req->info) of
> ablkcipher_request (or equivalently req->iv of skcipher_request) to
> contain the last ciphertext block when the {en,de}crypt operation is done.
> This is currently not the case for the CAAM driver which in turn breaks
> e.g. cts(cbc(aes)) when the CAAM driver is enabled.
> 
> This patch fixes the CAAM driver to properly set the IV after the
> {en,de}crypt operation of ablkcipher finishes.
> 
> This issue was revealed by the changes in the SW CTS mode in commit
> 0605c41cc53ca ("crypto: cts - Convert to skcipher")
> 
> Cc: <stable@vger.kernel.org> # 4.8+
> Signed-off-by: David Gstir <david@sigma-star.at>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      parent reply	other threads:[~2017-07-12 10:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 12:24 [RFC PATCH 0/2] crypto: caam - fix cts(cbc(aes)) with CAAM driver David Gstir
2017-06-02 12:24 ` [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt David Gstir
2017-06-19 10:31   ` Horia Geantă
2017-06-20  1:28     ` Herbert Xu
2017-06-26  5:40       ` David Gstir
2017-06-26  6:47         ` Herbert Xu
2017-06-28  8:32     ` Horia Geantă
2017-06-28  9:03       ` David Gstir
2017-06-02 12:24 ` [RFC PATCH 2/2] crypto: caam - fix k*alloc if called from own cipher callback David Gstir
2017-06-13 11:53 ` [RFC PATCH 0/2] crypto: caam - fix cts(cbc(aes)) with CAAM driver David Gstir
2017-06-15 14:57 ` Horia Geantă
2017-06-16  7:57   ` Horia Geantă
2017-06-16  7:59     ` Herbert Xu
2017-06-16 21:01       ` Horia Geantă
2017-06-17  9:05         ` David Gstir
2017-06-19  8:44           ` [PATCH 1/2] crypto: caam - fix gfp allocation flags (part I) Horia Geantă
2017-06-19  8:44             ` [PATCH 2/2] crypto: caam - fix gfp allocation flags (part II) Horia Geantă
2017-06-22  9:00               ` Herbert Xu
2017-06-22  9:00             ` [PATCH 1/2] crypto: caam - fix gfp allocation flags (part I) Herbert Xu
2017-06-28 13:27 ` [PATCH] crypto: caam - properly set IV after {en,de}crypt David Gstir
2017-06-28 13:42   ` Horia Geantă
2017-06-29 10:19     ` Horia Geantă
2017-08-14  7:59       ` Gilad Ben-Yossef
2017-09-05 15:33         ` Horia Geantă
2017-09-06 10:14           ` Gilad Ben-Yossef
2017-09-07 10:12             ` Horia Geantă
2017-07-12 10:51   ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712105156.GC22109@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=dan.douglass@nxp.com \
    --cc=davem@davemloft.net \
    --cc=david@sigma-star.at \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@sigma-star.at \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).