From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816AbdGNJjr (ORCPT ); Fri, 14 Jul 2017 05:39:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:55090 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753767AbdGNJjp (ORCPT ); Fri, 14 Jul 2017 05:39:45 -0400 Date: Fri, 14 Jul 2017 10:39:42 +0100 From: Mel Gorman To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Vlastimil Babka , LKML , Michal Hocko Subject: Re: [PATCH 2/9] mm, page_alloc: remove boot pageset initialization from memory hotplug Message-ID: <20170714093942.jzxq4jruixoj22x2@suse.de> References: <20170714080006.7250-1-mhocko@kernel.org> <20170714080006.7250-3-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170714080006.7250-3-mhocko@kernel.org> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2017 at 09:59:59AM +0200, Michal Hocko wrote: > From: Michal Hocko > > boot_pageset is a boot time hack which gets superseded by normal > pagesets later in the boot process. It makes zero sense to reinitialize > it again and again during memory hotplug. > > Signed-off-by: Michal Hocko You could also go slightly further and remove the batch parameter to setupo_pageset because it's always 0. Otherwise Acked-by: Mel Gorman -- Mel Gorman SUSE Labs