From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbdGNLip (ORCPT ); Fri, 14 Jul 2017 07:38:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:40798 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753486AbdGNLio (ORCPT ); Fri, 14 Jul 2017 07:38:44 -0400 Date: Fri, 14 Jul 2017 13:38:40 +0200 From: Michal Hocko To: Mel Gorman Cc: linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Vlastimil Babka , LKML , linux-api@vger.kernel.org Subject: Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE Message-ID: <20170714113840.GI2618@dhcp22.suse.cz> References: <20170714080006.7250-1-mhocko@kernel.org> <20170714080006.7250-2-mhocko@kernel.org> <20170714093650.l67vbem2g4typkta@suse.de> <20170714104756.GD2618@dhcp22.suse.cz> <20170714111633.gk5rpu2d5ghkbrrd@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170714111633.gk5rpu2d5ghkbrrd@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 14-07-17 12:16:33, Mel Gorman wrote: > On Fri, Jul 14, 2017 at 12:47:57PM +0200, Michal Hocko wrote: > > > That should to be "default" because the original code would have the proc > > > entry display "default" unless it was set at runtime. Pretty weird I > > > know but it's always possible someone is parsing the original default > > > and not handling it properly. > > > > Ohh, right! That is indeed strange. Then I guess it would be probably > > better to simply return Node to make it clear what the default is. What > > do you think? > > > > That would work too. The casing still matches. This folded in? --- >>From c7c36f011590680b254813be00ed791ddbc1bf1c Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Fri, 14 Jul 2017 13:36:05 +0200 Subject: [PATCH] fold me "mm, page_alloc: rip out ZONELIST_ORDER_ZONE" - do not print Default in sysctl handler because our behavior was rather inconsistent in the past numa_zonelist_order was lowecase while zonelist_order_name was uppercase so boot time unchanged value woul print lowercase while updated value could be uppercase. Print "Node" which is the default instead - Mel Signed-off-by: Michal Hocko --- mm/page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index dd4c96edcec3..49bade7ff049 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4828,8 +4828,8 @@ int numa_zonelist_order_handler(struct ctl_table *table, int write, int ret; if (!write) { - int len = sizeof("Default"); - if (copy_to_user(buffer, "Default", len)) + int len = sizeof("Node"); + if (copy_to_user(buffer, "Node", len)) return -EFAULT; return len; } -- 2.11.0 -- Michal Hocko SUSE Labs